Attachment #345123 for bug #187712

View Details Raw Unified Return to Bug 187712

| Differences between



2018-07-16  Ross Kirsling  <ross.kirsling@sony.com>

        TestWTF.WTF.StringConcatenate_Unsigned fails for unsigned short on Windows
        https://bugs.webkit.org/show_bug.cgi?id=187712

        Reviewed by NOBODY (OOPS!).

        * wtf/text/StringConcatenateNumbers.h:
        StringTypeAdapter should choose the UChar (and not UnsignedInt) path for unsigned short on Windows,
        where UChar is defined as wchar_t.

2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>

        Ensure WebKit stack is ad-hoc signed



    UnsignedInt m_number;
};

#if OS(WINDOWS)
template<>
class StringTypeAdapter<unsigned short, void> : public StringTypeAdapter<UChar, void> {
public:
    StringTypeAdapter(unsigned short character)
        : StringTypeAdapter<UChar, void>(character)
    {
    }
};
#endif

template<typename FloatingPoint>
class StringTypeAdapter<FloatingPoint, typename std::enable_if_t<std::is_floating_point<FloatingPoint>::value>> {
public:

Return to Bug 187712

Lines 1-3 a/Source/WTF/ChangeLog_sec1
- a/Source/WTF/ChangeLog +11 lines
		1	2018-07-16 Ross Kirsling <ross.kirsling@sony.com>
		2
		3	TestWTF.WTF.StringConcatenate_Unsigned fails for unsigned short on Windows
		4	https://bugs.webkit.org/show_bug.cgi?id=187712
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* wtf/text/StringConcatenateNumbers.h:
		9	StringTypeAdapter should choose the UChar (and not UnsignedInt) path for unsigned short on Windows,
		10	where UChar is defined as wchar_t.
		11
1	2018-07-14 Kocsen Chung <kocsen_chung@apple.com>	12	2018-07-14 Kocsen Chung <kocsen_chung@apple.com>
2		13
3	Ensure WebKit stack is ad-hoc signed	14	Ensure WebKit stack is ad-hoc signed

Lines 71-76 private: a/Source/WTF/wtf/text/StringConcatenateNumbers.h_sec1
- a/Source/WTF/wtf/text/StringConcatenateNumbers.h +11 lines
71	UnsignedInt m_number;	71	UnsignedInt m_number;
72	};	72	};
73		73
		74	#if OS(WINDOWS)
		75	template<>
		76	class StringTypeAdapter<unsigned short, void> : public StringTypeAdapter<UChar, void> {
		77	public:
		78	StringTypeAdapter(unsigned short character)
		79	: StringTypeAdapter<UChar, void>(character)
		80	{
		81	}
		82	};
		83	#endif
		84
74	template<typename FloatingPoint>	85	template<typename FloatingPoint>
75	class StringTypeAdapter<FloatingPoint, typename std::enable_if_t<std::is_floating_point<FloatingPoint>::value>> {	86	class StringTypeAdapter<FloatingPoint, typename std::enable_if_t<std::is_floating_point<FloatingPoint>::value>> {
76	public:	87	public: