Attachment #433126 for bug #225870

View Details Raw Unified Return to Bug 225870



2021-07-08  Chris Lord  <clord@igalia.com>

        [GLIB] Several offscreen canvas tests are failing since r277543
        https://bugs.webkit.org/show_bug.cgi?id=225870

        Reviewed by NOBODY (OOPS!).

        Tests now either passing or removed.

        * platform/glib/TestExpectations:

2021-06-30  Chris Lord  <clord@igalia.com>

        Pixel snapping is incorrect for async scrolled overflow layers



2021-07-08  Chris Lord  <clord@igalia.com>

        [GLIB] Several offscreen canvas tests are failing since r277543
        https://bugs.webkit.org/show_bug.cgi?id=225870

        Reviewed by NOBODY (OOPS!).

        Update to match upstream and fix false OffscreenCanvas failures.

        * web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic-expected.txt: Removed.
        * web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.worker-expected.txt: Removed.
        * web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.worker.html: Removed.
        * web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs.html:
        * web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs.worker.js:
        (t.step):

2021-07-06  Antti Koivisto  <antti@apple.com>

        Import basic :has() tests

Lines 1-7 a/LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic-expected.txt_sec1
- a/LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic-expected.txt -7 lines
1	2d.gradient.conic
2
3	Conic gradient function exists
4
5
6	FAIL Conic gradient function exists ctx.createConicGradient is not a function. (In 'ctx.createConicGradient(0, 0, 25)', 'ctx.createConicGradient' is undefined)
7

Lines 1-3 a/LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.worker-expected.txt_sec1
- a/LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.worker-expected.txt -3 lines
1
2	FAIL Conic gradient function exists ctx.createConicGradient is not a function. (In 'ctx.createConicGradient(0, 0, 25)', 'ctx.createConicGradient' is undefined)
3

Line 1 a/LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.worker.html_sec1
- a/LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.worker.html -1 lines
1	<!-- This file is required for WebKit test infrastructure to run the templated test -->



var offscreenCanvas = new OffscreenCanvas(100, 50);
var ctx = offscreenCanvas.getContext('2d');

_assertDifferent(offscreenCanvas.getContext('2d', false, {}, [], 1, "2"), null, "offscreenCanvas2.getContext('2d', false, {}, [], 1, \"2\")", "null");
_assertDifferent(offscreenCanvas.getContext('2d', 123), null, "offscreenCanvas2.getContext('2d', 123)", "null");
_assertDifferent(offscreenCanvas.getContext('2d', "test"), null, "offscreenCanvas2.getContext('2d', \"test\")", "null");
_assertDifferent(offscreenCanvas.getContext('2d', undefined), null, "offscreenCanvas2.getContext('2d', undefined)", "null");
_assertDifferent(offscreenCanvas.getContext('2d', null), null, "offscreenCanvas2.getContext('2d', null)", "null");
_assertDifferent(offscreenCanvas.getContext('2d', Symbol.hasInstance), null, "offscreenCanvas2.getContext('2d', Symbol.hasInstance)", "null");
_assertDifferent(offscreenCanvas2.getContext('2d', Symbol.hasInstance), null, "offscreenCanvas2.getContext('2d', Symbol.hasInstance)", "null");
t.done();

});



var offscreenCanvas = new OffscreenCanvas(100, 50);
var ctx = offscreenCanvas.getContext('2d');

_assertDifferent(offscreenCanvas.getContext('2d', false, {}, [], 1, "2"), null, "offscreenCanvas2.getContext('2d', false, {}, [], 1, \"2\")", "null");
_assertDifferent(offscreenCanvas.getContext('2d', 123), null, "offscreenCanvas2.getContext('2d', 123)", "null");
_assertDifferent(offscreenCanvas.getContext('2d', "test"), null, "offscreenCanvas2.getContext('2d', \"test\")", "null");
_assertDifferent(offscreenCanvas.getContext('2d', undefined), null, "offscreenCanvas2.getContext('2d', undefined)", "null");
_assertDifferent(offscreenCanvas.getContext('2d', null), null, "offscreenCanvas2.getContext('2d', null)", "null");
_assertDifferent(offscreenCanvas.getContext('2d', Symbol.hasInstance), null, "offscreenCanvas2.getContext('2d', Symbol.hasInstance)", "null");
_assertDifferent(offscreenCanvas2.getContext('2d', Symbol.hasInstance), null, "offscreenCanvas2.getContext('2d', Symbol.hasInstance)", "null");
t.done();

});



webkit.org/b/221311 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/filter/offscreencanvas.filter.w.html [ Slow ]
webkit.org/b/221311 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/filter/offscreencanvas.filter.w.html [ Slow ]

# Failing since r277543.
webkit.org/b/225870 imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.worker.html [ Failure ]
webkit.org/b/225870 imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs.html [ Failure ]
webkit.org/b/225870 imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs.worker.html [ Failure ]

#////////////////////////////////////////////////////////////////////////////////////////
# End of OffscreenCanvas-related bugs
#////////////////////////////////////////////////////////////////////////////////////////

Return to Bug 225870

Lines 758-768 webkit.org/b/215462 imported/w3c/web-platform-tests/html/canvas/offscreen/manual a/LayoutTests/platform/glib/TestExpectations_sec1
- a/LayoutTests/platform/glib/TestExpectations -5 lines
758	webkit.org/b/221311 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/filter/offscreencanvas.filter.w.html [ Slow ]	758	webkit.org/b/221311 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/filter/offscreencanvas.filter.w.html [ Slow ]
759	webkit.org/b/221311 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/filter/offscreencanvas.filter.w.html [ Slow ]	759	webkit.org/b/221311 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/filter/offscreencanvas.filter.w.html [ Slow ]
760		760
761	# Failing since r277543.
762	webkit.org/b/225870 imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.worker.html [ Failure ]
763	webkit.org/b/225870 imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs.html [ Failure ]
764	webkit.org/b/225870 imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs.worker.html [ Failure ]
765
766	#////////////////////////////////////////////////////////////////////////////////////////	761	#////////////////////////////////////////////////////////////////////////////////////////
767	# End of OffscreenCanvas-related bugs	762	# End of OffscreenCanvas-related bugs
768	#////////////////////////////////////////////////////////////////////////////////////////	763	#////////////////////////////////////////////////////////////////////////////////////////

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +11 lines
		1	2021-07-08 Chris Lord <clord@igalia.com>
		2
		3	[GLIB] Several offscreen canvas tests are failing since r277543
		4	https://bugs.webkit.org/show_bug.cgi?id=225870
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Tests now either passing or removed.
		9
		10	* platform/glib/TestExpectations:
		11
1	2021-06-30 Chris Lord <clord@igalia.com>	12	2021-06-30 Chris Lord <clord@igalia.com>
2		13
3	Pixel snapping is incorrect for async scrolled overflow layers	14	Pixel snapping is incorrect for async scrolled overflow layers

Lines 1-3 a/LayoutTests/imported/w3c/ChangeLog_sec1
- a/LayoutTests/imported/w3c/ChangeLog +16 lines
		1	2021-07-08 Chris Lord <clord@igalia.com>
		2
		3	[GLIB] Several offscreen canvas tests are failing since r277543
		4	https://bugs.webkit.org/show_bug.cgi?id=225870
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Update to match upstream and fix false OffscreenCanvas failures.
		9
		10	* web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic-expected.txt: Removed.
		11	* web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.worker-expected.txt: Removed.
		12	* web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.worker.html: Removed.
		13	* web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs.html:
		14	* web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs.worker.js:
		15	(t.step):
		16
1	2021-07-06 Antti Koivisto <antti@apple.com>	17	2021-07-06 Antti Koivisto <antti@apple.com>
2		18
3	Import basic :has() tests	19	Import basic :has() tests

Lines 20-32 t.step(function() { a/LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs.html_sec1
- a/LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs.html -7 / +6 lines
20	var offscreenCanvas = new OffscreenCanvas(100, 50);	20	var offscreenCanvas = new OffscreenCanvas(100, 50);
21	var ctx = offscreenCanvas.getContext('2d');	21	var ctx = offscreenCanvas.getContext('2d');
22		22
23	var offscreenCanvas2 = new OffscreenCanvas(100, 50);	23	_assertDifferent(offscreenCanvas.getContext('2d', false, {}, [], 1, "2"), null, "offscreenCanvas2.getContext('2d', false, {}, [], 1, \"2\")", "null");
24	_assertDifferent(offscreenCanvas2.getContext('2d', false, {}, [], 1, "2"), null, "offscreenCanvas2.getContext('2d', false, {}, [], 1, \"2\")", "null");	24	_assertDifferent(offscreenCanvas.getContext('2d', 123), null, "offscreenCanvas2.getContext('2d', 123)", "null");
25	_assertDifferent(offscreenCanvas2.getContext('2d', 123), null, "offscreenCanvas2.getContext('2d', 123)", "null");	25	_assertDifferent(offscreenCanvas.getContext('2d', "test"), null, "offscreenCanvas2.getContext('2d', \"test\")", "null");
26	_assertDifferent(offscreenCanvas2.getContext('2d', "test"), null, "offscreenCanvas2.getContext('2d', \"test\")", "null");	26	_assertDifferent(offscreenCanvas.getContext('2d', undefined), null, "offscreenCanvas2.getContext('2d', undefined)", "null");
27	_assertDifferent(offscreenCanvas2.getContext('2d', undefined), null, "offscreenCanvas2.getContext('2d', undefined)", "null");	27	_assertDifferent(offscreenCanvas.getContext('2d', null), null, "offscreenCanvas2.getContext('2d', null)", "null");
28	_assertDifferent(offscreenCanvas2.getContext('2d', null), null, "offscreenCanvas2.getContext('2d', null)", "null");	28	_assertDifferent(offscreenCanvas.getContext('2d', Symbol.hasInstance), null, "offscreenCanvas2.getContext('2d', Symbol.hasInstance)", "null");
29	_assertDifferent(offscreenCanvas2.getContext('2d', Symbol.hasInstance), null, "offscreenCanvas2.getContext('2d', Symbol.hasInstance)", "null");
30	t.done();	29	t.done();
31		30
32	});	31	});