Tools/ChangeLog

 12017-08-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
 2
 3 REGRESSION(r219850): run-benchmark script broken on Linux
 4 https://bugs.webkit.org/show_bug.cgi?id=175126
 5
 6 Reviewed by NOBODY (OOPS!).
 7
 8 The run-benchmark script dynamically generates the list of supported
 9 browsers and platforms (currently Linux and OSX) by loading all
 10 python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
 11 and getting the browser_name and platform variables from the
 12 classes defined there.
 13
 14 This means that this classes should not raise an exception when
 15 loaded on other platforms or otherwise they will broke the whole
 16 script. Its fine if they raise an exception when executing any of
 17 the methods they implement, but not when just loading/importing
 18 the class.
 19
 20 Move the argument variable definitions that call on the platform
 21 specific OSXBrowserDriver._screen_size() function from the main
 22 files to the launch_url() function definition.
 23
 24 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
 25 (OSXChromeDriver.launch_url):
 26 (OSXChromeCanaryDriver.launch_url):
 27 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
 28 (OSXFirefoxDriver.launch_url):
 29 (OSXFirefoxNightlyDriver.launch_url):
 30
1312017-08-02 Youenn Fablet <youenn@apple.com>
232
333 HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1

Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py

@@from osx_browser_driver import OSXBrowserDriver
77
88
99_log = logging.getLogger(__name__)
10 window_size_arg = '--window-size={width},{height}'.format(width=int(OSXBrowserDriver._screen_size().width), height=int(OSXBrowserDriver._screen_size().height))
11 args = ['--args', '--homepage', window_size_arg]
1210
1311class OSXChromeDriver(OSXBrowserDriver):
1412 process_name = 'Google Chrome'

@@class OSXChromeDriver(OSXBrowserDriver):
1614 app_name = 'Google Chrome.app'
1715
1816 def launch_url(self, url, options, browser_build_path):
 17 window_size_arg = '--window-size={width},{height}'.format(width=int(OSXBrowserDriver._screen_size().width), height=int(OSXBrowserDriver._screen_size().height))
 18 args = ['--args', '--homepage', window_size_arg]
1919 args_with_url = self._insert_url(args, 2, url)
2020 self._launch_process(build_dir=browser_build_path, app_name=self.app_name, url=url, args=args_with_url)
2121

@@class OSXChromeCanaryDriver(OSXBrowserDriver):
3838 app_name = 'Google Chrome Canary.app'
3939
4040 def launch_url(self, url, options, browser_build_path):
 41 window_size_arg = '--window-size={width},{height}'.format(width=int(OSXBrowserDriver._screen_size().width), height=int(OSXBrowserDriver._screen_size().height))
 42 args = ['--args', '--homepage', window_size_arg]
4143 args_with_url = self._insert_url(args, 2, url)
4244 self._launch_process(build_dir=browser_build_path, app_name=self.app_name, url=url, args=args_with_url)
4345

Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py

@@from osx_browser_driver import OSXBrowserDriver
88
99_log = logging.getLogger(__name__)
1010
11 args = ['--args', '-width', str(int(OSXBrowserDriver._screen_size().width)), '-height', str(int(OSXBrowserDriver._screen_size().height))]
12 
13 
1411class OSXFirefoxDriver(OSXBrowserDriver):
1512 process_name = 'firefox'
1613 browser_name = 'firefox'
1714 app_name = 'Firefox.app'
1815
1916 def launch_url(self, url, options, browser_build_path):
 17 args = ['--args', '-width', str(int(OSXBrowserDriver._screen_size().width)), '-height', str(int(OSXBrowserDriver._screen_size().height))]
2018 args_with_url = self._insert_url(args, 0, url)
2119 self._launch_process(build_dir=browser_build_path, app_name=self.app_name, url=url, args=args_with_url)
2220

@@class OSXFirefoxNightlyDriver(OSXBrowserDriver):
4038 app_name = 'FirefoxNightly.app'
4139
4240 def launch_url(self, url, options, browser_build_path):
 41 args = ['--args', '-width', str(int(OSXBrowserDriver._screen_size().width)), '-height', str(int(OSXBrowserDriver._screen_size().height))]
4342 args_with_url = self._insert_url(args, 0, url)
4443 self._launch_process(build_dir=browser_build_path, app_name=self.app_name, url=url, args=args_with_url)
4544