ChangeLog

2018-09-03  Frederic Wang  <fwang@igalia.com>

        Bug 189190 - REGRESSION(r235398) ASSERTION failure !m_client.didFinishDocumentLoadForFrame

        https://bugs.webkit.org/show_bug.cgi?id=189190

        Reviewed by NOBODY (OOPS!).

        Assertions to prevent use of the deprecated WKPageSetPageLoaderClient class are hit when

        running system Safari with the current macOS/iOS releases, making impossible to launch it.

        This patch conditionally skips these assertions so that they are only verified for

        macOS >= 10.14 and iOS >= 12.

        * UIProcess/API/C/WKPage.cpp:

        (WKPageSetPageLoaderClient): Only assert on future OS releases.

2018-09-01  Darin Adler  <darin@apple.com>

        [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently

Source/WebKit/UIProcess/API/C/WKPage.cpp

@@void WKPageSetPageLoaderClient(WKPageRef pageRef, const WKPageLoaderClientBase*

        {

            initialize(client);

1046#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 120000)

            // WKPageSetPageLoaderClient is deprecated. Use WKPageSetPageNavigationClient instead.

            RELEASE_ASSERT(!m_client.didFinishDocumentLoadForFrame);

            RELEASE_ASSERT(!m_client.didSameDocumentNavigationForFrame);

@@void WKPageSetPageLoaderClient(WKPageRef pageRef, const WKPageLoaderClientBase*

            RELEASE_ASSERT(!m_client.navigationGestureDidBegin);

            RELEASE_ASSERT(!m_client.navigationGestureWillEnd);

            RELEASE_ASSERT(!m_client.navigationGestureDidEnd);

1079#endif

        }

    private: