Source/WebCore/ChangeLog

 12018-10-17 Thibault Saunier <tsaunier@igalia.com>
 2
 3 [GStreamer][WebRTC] Error out when simulcast is activated
 4 https://bugs.webkit.org/show_bug.cgi?id=190678
 5
 6 Reviewed by Philippe Normand.
 7
 8 Implementing it is not for now yet.
 9
 10 Tests for simulcast have been disabled as they now fail (instead of crashing).
 11
 12 * platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
 13 (WebCore::GStreamerVideoEncoder::InitEncode):
 14
1152018-11-05 Thibault Saunier <tsaunier@igalia.com>
216
317 [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders

Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp

3131#include "webrtc/modules/video_coding/codecs/h264/include/h264.h"
3232#include "webrtc/modules/video_coding/codecs/vp8/include/vp8.h"
3333#include "webrtc/modules/video_coding/include/video_codec_interface.h"
 34#include "webrtc/modules/video_coding/utility/simulcast_utility.h"
3435
3536#include <gst/app/gstappsink.h>
3637#include <gst/app/gstappsrc.h>

@@public:
106107 g_return_val_if_fail(codecSettings, WEBRTC_VIDEO_CODEC_ERR_PARAMETER);
107108 g_return_val_if_fail(codecSettings->codecType == CodecType(), WEBRTC_VIDEO_CODEC_ERR_PARAMETER);
108109
 110 if (webrtc::SimulcastUtility::NumberOfSimulcastStreams(*codecSettings) > 1) {
 111 GST_ERROR("Simulcast not supported.");
 112
 113 return WEBRTC_VIDEO_CODEC_ERR_SIMULCAST_PARAMETERS_NOT_SUPPORTED;
 114 }
 115
109116 m_encodedFrame._size = codecSettings->width * codecSettings->height * 3;
110117 m_encodedFrame._buffer = new uint8_t[m_encodedFrame._size];
111118 m_encodedImageBuffer.reset(m_encodedFrame._buffer);

LayoutTests/ChangeLog

 12018-10-17 Thibault Saunier <tsaunier@igalia.com>
 2
 3 [GStreamer][WebRTC] Error out when simulcast is activated
 4 https://bugs.webkit.org/show_bug.cgi?id=190678
 5
 6 Reviewed by Philippe Normand.
 7
 8 Implementing it is not for now yet.
 9 Tests for simulcast have been disabled as they now fail (instead of crashing).
 10
 11 * platform/gtk/TestExpectations:
 12 * platform/wpe/TestExpectations:
 13
1142018-11-05 Zan Dobersek <zdobersek@igalia.com>
215
316 Unreviewed WPE gardening. Updating or adding various baselines. Also

LayoutTests/platform/wpe/TestExpectations

4646#////////////////////////////////////////////////////////////////////////////////////////
4747
4848# The webrtc implementation is not fully completed yet
 49webkit.org/b/187064 webrtc/simulcast-h264.html
4950webkit.org/b/189567 webrtc/video-addLegacyTransceiver.html [ Failure ]
5051webkit.org/b/187064 webrtc/audio-peer-connection-g722.html
5152webkit.org/b/187064 webrtc/video-with-receiver.html