Bug 100355

Summary: Allow LoaderStrategy to override the ResourceLoadScheduler
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, gyuyoung.kim, japhet, rakuco, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 98539    
Attachments:
Description Flags
Patch v1 - Get the EWS ball rolling
none
Patch v2 - Applies?
andersca: review+, webkit-ews: commit-queue-
Patch v3 - Fix non NETWORK_PROCESS builds. none

Brady Eidson
Reported 2012-10-25 01:52:49 PDT
Allow LoaderStrategy to override the ResourceLoadScheduler This will include a default implementation that returns the current WebCore ResourceLoadScheduler. It will also include a WebKit2 implementation of a WebResourceLoadScheduler that doesn't do anything differently (yet)
Attachments
Patch v1 - Get the EWS ball rolling (32.65 KB, patch)
2012-10-25 02:07 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v2 - Applies? (32.68 KB, patch)
2012-10-25 09:07 PDT, Brady Eidson 		andersca: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch v3 - Fix non NETWORK_PROCESS builds. (32.70 KB, patch)
2012-10-25 09:15 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2012-10-25 02:07:21 PDT
Created attachment 170591 [details] Patch v1 - Get the EWS ball rolling
Brady Eidson
Comment 2 2012-10-25 09:07:07 PDT
Created attachment 170666 [details] Patch v2 - Applies?
WebKit Review Bot
Comment 3 2012-10-25 09:10:45 PDT
Attachment 170666 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/loader/cache/CachedResourceLoader.cpp:50: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:25: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 4 2012-10-25 09:12:07 PDT
Comment on attachment 170666 [details] Patch v2 - Applies? Attachment 170666 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14554681
Brady Eidson
Comment 5 2012-10-25 09:15:58 PDT
Created attachment 170668 [details] Patch v3 - Fix non NETWORK_PROCESS builds.
Brady Eidson
Comment 6 2012-10-25 09:57:08 PDT
EWS bots are way behind this morning... I'll wait on a couple more.
Brady Eidson
Comment 7 2012-10-25 10:17:06 PDT
http://trac.webkit.org/changeset/132501
Note You need to log in before you can comment on or make changes to this bug.