Bug 102699

Summary: [Chromium][Win] Remove theme-related functions from PlatformSupport
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, fishd, haraken, ojan.autocc, ojan, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Re-patched to ToT
none
Repatched to ToT
none
Patch none

Mark Pilgrim (Google)
Reported 2012-11-19 11:20:16 PST
[Chromium][Win] Remove theme-related functions from PlatformSupport
Attachments
Patch (19.10 KB, patch)
2012-11-19 11:23 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Re-patched to ToT (19.17 KB, patch)
2012-11-28 10:58 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Repatched to ToT (19.21 KB, patch)
2012-12-04 13:05 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (17.35 KB, patch)
2012-12-10 11:10 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-11-19 11:23:35 PST
Created attachment 175010 [details] Patch
Mark Pilgrim (Google)
Comment 2 2012-11-28 10:58:18 PST
Created attachment 176524 [details] Re-patched to ToT
Adam Barth
Comment 3 2012-11-28 12:47:11 PST
Comment on attachment 176524 [details] Re-patched to ToT View in context: https://bugs.webkit.org/attachment.cgi?id=176524&action=review > Source/WebKit/chromium/src/PlatformSupport.cpp:-205 > - RGBA32 backgroundColor = color.isValid() ? color.rgb() : Color::white; I see. This is redundant with the work done by the one caller. Nice.
Mark Pilgrim (Google)
Comment 4 2012-12-04 13:05:02 PST
Created attachment 177532 [details] Repatched to ToT
WebKit Review Bot
Comment 5 2012-12-05 12:31:11 PST
Comment on attachment 177532 [details] Repatched to ToT Clearing flags on attachment: 177532 Committed r136735: <http://trac.webkit.org/changeset/136735>
WebKit Review Bot
Comment 6 2012-12-05 12:31:15 PST
All reviewed patches have been landed. Closing bug.
Stephen White
Comment 7 2012-12-05 13:18:52 PST
Reverted r136735 for reason: Broke Chrome/Win build. Committed r136749: <http://trac.webkit.org/changeset/136749>
Mark Pilgrim (Google)
Comment 8 2012-12-10 11:10:25 PST
Created attachment 178595 [details] Patch
Mark Pilgrim (Google)
Comment 9 2012-12-10 11:10:52 PST
Comment on attachment 178595 [details] Patch Fixed downstream issues, repatched to ToT.
Stephen White
Comment 10 2012-12-10 12:36:12 PST
Has the appropriate Chrome revision been rolled into WebKit? (Source/WebKit/chromium/DEPS)
Darin Fisher (:fishd, Google)
Comment 11 2012-12-10 12:43:21 PST
(In reply to comment #10) > Has the appropriate Chrome revision been rolled into WebKit? (Source/WebKit/chromium/DEPS) This isn't changing WebKit API, so there should be no such dependency.
WebKit Review Bot
Comment 12 2012-12-10 13:34:17 PST
Comment on attachment 178595 [details] Patch Clearing flags on attachment: 178595 Committed r137201: <http://trac.webkit.org/changeset/137201>
WebKit Review Bot
Comment 13 2012-12-10 13:34:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.