Bug 107283

Summary:

Consolidate and run ARIA-list-and-listitem accessibility test

Product:

WebKit

Reporter:

Brian Holt <brian.holt>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, buildbot, cfleizach, dglazkov, dmazzoni, jdiggs, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Unspecified

Attachments:

Description	Flags
Patch proposal	none
2nd patch proposal	none
Made exception for Mac	none

Brian Holt

Reported 2013-01-18 07:38:41 PST

After bug 99640, the output from AccessibilityUIElement::role() is consistent across platforms, therefore platform specific tests can be consolidated into a single test and enabled.

Attachments
Patch proposal (5.13 KB, patch) 2013-01-18 09:00 PST, Brian Holt	no flags	Details Formatted Diff Diff
2nd patch proposal (5.14 KB, patch) 2013-01-18 09:44 PST, Brian Holt	no flags	Details Formatted Diff Diff
Made exception for Mac (4.37 KB, patch) 2013-01-21 06:53 PST, Brian Holt	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brian Holt

Comment 1 2013-01-18 09:00:58 PST

Created attachment 183472 [details] Patch proposal

Brian Holt

Comment 2 2013-01-18 09:02:58 PST

Adding people who might be interested to CC.

Alexey Proskuryakov

Comment 3 2013-01-18 09:31:59 PST

Comment on attachment 183472 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=183472&action=review > LayoutTests/ChangeLog:10 > + therefore platform specific tests can be consolidated into a Did you mean to say "platform specific expectations"?

Brian Holt

Comment 4 2013-01-18 09:44:35 PST

Created attachment 183487 [details] 2nd patch proposal

WebKit Review Bot

Comment 5 2013-01-18 10:53:50 PST

Comment on attachment 183487 [details] 2nd patch proposal Attachment 183487 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15957218 New failing tests: accessibility/aria-list-and-listitem.html

Build Bot

Comment 6 2013-01-18 11:42:40 PST

Comment on attachment 183487 [details] 2nd patch proposal Attachment 183487 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/15944666 New failing tests: accessibility/aria-list-and-listitem.html

Build Bot

Comment 7 2013-01-18 11:49:13 PST

Comment on attachment 183487 [details] 2nd patch proposal Attachment 183487 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15946543 New failing tests: accessibility/aria-list-and-listitem.html

Brian Holt

Comment 8 2013-01-21 06:53:00 PST

Created attachment 183776 [details] Made exception for Mac

chris fleizach

Comment 9 2013-01-21 09:05:37 PST

Comment on attachment 183776 [details] Made exception for Mac what's the mac exception? i don't see anything referencing an exception with this patch

Brian Holt

Comment 10 2013-01-21 09:36:32 PST

The previous patch that I proposed removed the mac-specific expectation in favour of a generic test expectation, but I was mistaken - there should be an platform specific expectation for mac (which is what I named this 3rd proposal).

chris fleizach

Comment 11 2013-01-21 09:41:57 PST

(In reply to comment #10) > The previous patch that I proposed removed the mac-specific expectation in favour of a generic test expectation, but I was mistaken - there should be an platform specific expectation for mac (which is what I named this 3rd proposal). your change log says "Mac exception" - i guess you meant to say "Mac expectation" (?)

Brian Holt

Comment 12 2013-01-21 09:46:38 PST

> your change log says "Mac exception" - i guess you meant to say "Mac expectation" (?) I suppose I could have been clearer - what I mean is that the output is now the same on most platforms (i.e. a generic expectation) with the exception of Mac (which still requires a platform-specific expectation). Would you prefer me to update the ChangeLog?

chris fleizach

Comment 13 2013-01-21 09:49:42 PST

Comment on attachment 183776 [details] Made exception for Mac thanks. understand now

Brian Holt

Comment 14 2013-01-21 09:53:31 PST

Comment on attachment 183776 [details] Made exception for Mac Ready to commit?

WebKit Review Bot

Comment 15 2013-01-21 10:28:26 PST

Comment on attachment 183776 [details] Made exception for Mac Clearing flags on attachment: 183776 Committed r140343: <http://trac.webkit.org/changeset/140343>

WebKit Review Bot

Comment 16 2013-01-21 10:28:32 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.