Bug 107541

Summary: [GTK] [WTR] Move ActivateFontsGtk::getTopLevelPath() to utilities file
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: cgarcia, mrobinson, pnormand, webkit.review.bot, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107538    
Attachments:
Description Flags
Patch
none
Patch none

Manuel Rego Casasnovas
Reported 2013-01-22 02:49:01 PST
getTopLevelPath from Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp will be needed in Tools/WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp too (see bug #107538). So the function should be moved to a utilities file in order to share the code.
Attachments
Patch (8.68 KB, patch)
2013-01-22 02:55 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (8.51 KB, patch)
2013-01-28 08:10 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2013-01-22 02:55:37 PST
Created attachment 183948 [details] Patch
Martin Robinson
Comment 2 2013-01-28 07:33:06 PST
Comment on attachment 183948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183948&action=review > Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:36 > +#include "InjectedBundleUtilities.h" > + > #include <fontconfig/fontconfig.h> There should be no newline gap here between system includes and relative includes. > Tools/WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:37 > +namespace Util { Probably the WTR namespace is enough and you can avoid the Util namespace. > Tools/WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:48 > +/** > + * Returns the top level directory from WEBKIT_TOP_LEVEL environment > + * variable. > + * > + * If the environment variable wasn't provided then assume we were built > + * into WebKitBuild/Debug or WebKitBuild/Release. Obviously this will fail > + * if the build directory is non-standard, but we can't do much more about > + * this. > + * > + * @return the top level path. > + */ > +CString topLevelPath(); We don't typically add gtkdoc comments for non-API methods.
Manuel Rego Casasnovas
Comment 3 2013-01-28 08:10:19 PST
Created attachment 184985 [details] Patch
WebKit Review Bot
Comment 4 2013-01-28 08:29:40 PST
Comment on attachment 184985 [details] Patch Clearing flags on attachment: 184985 Committed r140969: <http://trac.webkit.org/changeset/140969>
WebKit Review Bot
Comment 5 2013-01-28 08:29:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.