Bug 112883

Summary: [meta][Chromium] Implement page cache support
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, eric, gavinp, laszlo.gombos, ostap73, schenney
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: https://code.google.com/p/chromium/issues/detail?id=2879
Bug Depends on: 112884, 112885, 112887    
Bug Blocks:    
Attachments:
Description Flags
Full WIP patch for reference
none
Full WIP patch for reference
none
Full WIP patch for reference none

Chris Dumez
Reported 2013-03-21 00:36:04 PDT
The chromium port does not currently enable page cache support. With the default process model in Chromium (Process per site instance), the page cache may not work as expected because a new process may be created when navigating to a new site instance. However, page cache would work correctly with minor modifications for other process models (process per tab or single process). Given that chromium supports different process models and that page cache would be beneficial for at least some of them. I propose to implement page cache support in chromium port.
Attachments
Full WIP patch for reference (17.20 KB, patch)
2013-03-21 00:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Full WIP patch for reference (20.37 KB, patch)
2013-03-21 03:42 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Full WIP patch for reference (17.37 KB, patch)
2013-03-21 08:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-03-21 00:47:13 PDT
Created attachment 194197 [details] Full WIP patch for reference Posting a full WIP patch here for reference. The idea is to split it and get review in separate sub-bugs though.
Chris Dumez
Comment 2 2013-03-21 01:21:40 PDT
Useful manual test case: http://www.twmagic.com/misc/cache-nocache.html
Chris Dumez
Comment 3 2013-03-21 03:42:19 PDT
Created attachment 194216 [details] Full WIP patch for reference
Chris Dumez
Comment 4 2013-03-21 08:38:28 PDT
Created attachment 194270 [details] Full WIP patch for reference Revert WebHistoryItem changes as this should probably be solved on Chromium side, not WebKit side.
Adam Barth
Comment 5 2013-03-21 09:52:55 PDT
It's not clear to me that we want to support the PageCache in Chromium. We should discuss that first before landing these patches.
Laszlo Gombos
Comment 6 2013-03-21 17:08:00 PDT
(In reply to comment #5) > It's not clear to me that we want to support the PageCache in Chromium. We should discuss that first before landing these patches. Adam, can you help the discussion by listing your concerns ? The combination of the existing --enable-fastback chromium command line options, the open chromium bug with a few dups and some related patches landed (e.g. r110998) let us believe that page cache for chromium would be a value at least conditionally (in case it is not enabled by default).
Adam Barth
Comment 7 2013-03-21 17:39:26 PDT
I'm about to go on vacation. Perhaps we should discuss the topic on chromium-dev when I get back? My main concerns are memory usage, complexity, and the interaction with the multiprocess architecture.
Stephen Chenney
Comment 8 2013-04-08 16:56:48 PDT
Shift all discussion to the Chromium bug.
Note You need to log in before you can comment on or make changes to this bug.