Bug 113601

Summary: Make a bunch of DocumentLoader functions private
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, koivisto, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
Patch for landing none

Nate Chapin
Reported 2013-03-29 13:22:11 PDT
After merging MainResourceLoader into DocumentLoader (http://trac.webkit.org/changeset/146449), several functions that were only public for MainResourceLoader's use can now be private. Also, a couple of functions are declared but unused.
Attachments
patch (5.70 KB, patch)
2013-03-29 13:25 PDT, Nate Chapin 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.70 KB, patch)
2013-04-01 09:33 PDT, Nate Chapin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2013-03-29 13:25:39 PDT
Created attachment 195787 [details] patch
WebKit Review Bot
Comment 2 2013-03-29 15:13:33 PDT
Comment on attachment 195787 [details] patch Rejecting attachment 195787 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 195787, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 14075 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 55>At revision 14075. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://webkit-commit-queue.appspot.com/results/17300493
Adam Barth
Comment 3 2013-03-30 10:49:37 PDT
Comment on attachment 195787 [details] patch Looks like you're missing a ChangeLog.
Nate Chapin
Comment 4 2013-04-01 09:28:33 PDT
(In reply to comment #3) > (From update of attachment 195787 [details]) > Looks like you're missing a ChangeLog. Yeah, I tried to get clever with diffing and failed. Re-uploading now.
Nate Chapin
Comment 5 2013-04-01 09:33:44 PDT
Created attachment 195981 [details] Patch for landing
WebKit Review Bot
Comment 6 2013-04-01 09:52:37 PDT
Comment on attachment 195981 [details] Patch for landing Clearing flags on attachment: 195981 Committed r147336: <http://trac.webkit.org/changeset/147336>
WebKit Review Bot
Comment 7 2013-04-01 09:52:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.