Bug 119946

Summary: Move some code used only by EventHandler from Clipboard to EventHandler
Product: WebKit Reporter: Darin Adler <darin>
Component: UI EventsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, kangil.han
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 115980    
Attachments:
Description Flags
Patch kling: review+

Darin Adler
Reported 2013-08-17 07:14:30 PDT
Move some code used only by EventHandler from Clipboard to EventHandler
Attachments
Patch (8.08 KB, patch)
2013-08-17 07:18 PDT, Darin Adler 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-08-17 07:18:36 PDT
Created attachment 208995 [details] Patch
Andreas Kling
Comment 2 2013-08-17 07:38:47 PDT
Comment on attachment 208995 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208995&action=review r=me > Source/WebCore/page/EventHandler.cpp:2037 > +static inline bool hasFileOfType(Clipboard* clipboard, const String& type) I'd use Clipboard& here. > Source/WebCore/page/EventHandler.cpp:2047 > +static inline bool hasStringOfType(Clipboard* clipboard, const String& type) Ditto. > Source/WebCore/page/EventHandler.cpp:2052 > +static bool hasDropZoneType(Clipboard* clipboard, const String& keyword) Ditto.
Darin Adler
Comment 3 2013-08-17 07:55:38 PDT
Committed r154229: <http://trac.webkit.org/changeset/154229>
Note You need to log in before you can comment on or make changes to this bug.