Bug 125441

Summary: [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebKitGTKAssignee: Alejandro G. Castro <alex>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Bug Depends on:    
Bug Blocks: 116317    
Attachments:
Description Flags
Patch
none
Patch none

Alejandro G. Castro
Reported 2013-12-09 01:27:24 PST
It is causing issues in the my environment when building the xml file output.
Attachments
Patch (1.32 KB, patch)
2013-12-09 01:34 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch (1.39 KB, patch)
2013-12-11 09:12 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2013-12-09 01:34:02 PST
Created attachment 218738 [details] Patch
Martin Robinson
Comment 2 2013-12-09 01:50:07 PST
Comment on attachment 218738 [details] Patch Hrm...what is the issue with escaping?
Alejandro G. Castro
Comment 3 2013-12-09 02:01:07 PST
(In reply to comment #2) > (From update of attachment 218738 [details]) > Hrm...what is the issue with escaping? It is building the pathname incorrectly, replacing using some pathname, and as the next line shows it is not required. I'm also interested on knowing what python is actually doing :).
Alejandro G. Castro
Comment 4 2013-12-11 09:02:50 PST
So, apparently it is a bug in some versions of valgrind, just checked if you run this it fails: VALGRIND_OPTS='--xml-file="/tmp/errors.xml"' valgrind /bin/ps valgrind: can't create XML file '/tmp/"/tmp/errors.xml"': No such file or directory My version is 3.8.1 in fedora 18. Considering we do not need the double quotes because we define the file name, it is safe to remove them and we can forget about this bug. I'll modify the information about the problem and upload the patch.
Alejandro G. Castro
Comment 5 2013-12-11 09:12:04 PST
Created attachment 218971 [details] Patch
WebKit Commit Bot
Comment 6 2013-12-11 11:00:25 PST
Comment on attachment 218971 [details] Patch Clearing flags on attachment: 218971 Committed r160448: <http://trac.webkit.org/changeset/160448>
WebKit Commit Bot
Comment 7 2013-12-11 11:00:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.