Bug 146392

Summary: Web Inspector: Wrong border color of console messages when filters are enabled
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Animated GIF] Actual/expected
none
Patch
timothy: review+
Patch none

Nikita Vasilyev
Reported 2015-06-27 21:45:07 PDT
Created attachment 255718 [details] [Animated GIF] Actual/expected Steps: 1. console.warn('a'); console.log('b'); console.warn('c'); console.error('d'); console.log('e'); console.error('f'); 2. Turn errors filter on.
Attachments
[Animated GIF] Actual/expected (4.53 KB, image/gif)
2015-06-27 21:45 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.70 KB, patch)
2015-06-27 21:49 PDT, Nikita Vasilyev 		timothy: review+
DetailsFormatted DiffDiff
Patch (1.65 KB, patch)
2015-06-27 23:54 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-06-27 21:45:23 PDT
<rdar://problem/21581992>
Nikita Vasilyev
Comment 2 2015-06-27 21:49:17 PDT
Created attachment 255719 [details] Patch
Timothy Hatcher
Comment 3 2015-06-27 22:46:45 PDT
Comment on attachment 255719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255719&action=review > Source/WebInspectorUI/UserInterface/Views/LogContentView.css:53 > +.console-error-level.console-item:not(.filtered-out):not(.filtered-out-by-search), Could be :not(.filtered-out, .filtered-out-by-search) > Source/WebInspectorUI/UserInterface/Views/LogContentView.css:54 > +.console-error-level:not(.filtered-out):not(.filtered-out-by-search) + .console-item { Ditto. > Source/WebInspectorUI/UserInterface/Views/LogContentView.css:58 > +.console-warning-level.console-item:not(.filtered-out):not(.filtered-out-by-search), Ditto. > Source/WebInspectorUI/UserInterface/Views/LogContentView.css:59 > +.console-warning-level:not(.filtered-out):not(.filtered-out-by-search) + .console-item { Ditto.
Nikita Vasilyev
Comment 4 2015-06-27 23:54:37 PDT
Created attachment 255721 [details] Patch
WebKit Commit Bot
Comment 5 2015-06-28 00:44:07 PDT
Comment on attachment 255721 [details] Patch Clearing flags on attachment: 255721 Committed r186042: <http://trac.webkit.org/changeset/186042>
WebKit Commit Bot
Comment 6 2015-06-28 00:44:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.