Bug 154644

Summary: Web Inspector: TimelineViews should use the recording's end time when entire ruler range is selected
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 153033    
Attachments:
Description Flags
[Video] capturing w/ select all enabled
none
[Patch] Proposed Fix none

Matt Baker
Reported 2016-02-24 10:57:19 PST
* SUMMARY TimelineViews should use the recording's end time when entire ruler range is selected. When everything is selected, TimelineRuler.selectionEndTime is equal to Number.MAX_VALUE. Grid-based timeline views can make use this value for filtering/updating rows, but graph-based views (OverviewTimelineView and MemoryTimelineView) require an actual time value to draw graph bars, etc. When "select all" is enabled, TimelineRecordingContentView should set a massaged end time for child timeline views: 1. While capturing, the recording end time is NaN, so use the current time. 2. When not capturing, the recording end time should be used.
Attachments
[Video] capturing w/ select all enabled (2.06 MB, video/mp4)
2016-02-24 10:58 PST, Matt Baker 		no flags
Details
[Patch] Proposed Fix (4.99 KB, patch)
2016-02-24 11:12 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-24 10:57:56 PST
<rdar://problem/24818442>
Matt Baker
Comment 2 2016-02-24 10:58:26 PST
Created attachment 272121 [details] [Video] capturing w/ select all enabled OverviewTimelineView live-updates
Matt Baker
Comment 3 2016-02-24 11:12:27 PST
Created attachment 272123 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 4 2016-02-24 12:19:43 PST
Comment on attachment 272123 [details] [Patch] Proposed Fix Clearing flags on attachment: 272123 Committed r197039: <http://trac.webkit.org/changeset/197039>
WebKit Commit Bot
Comment 5 2016-02-24 12:19:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.