Bug 162916

Summary: [DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, ossy, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 162544    
Attachments:
Description Flags
Patch
fpizlo: review+
Patch for landing
none
Patch for landing
none
Patch for landing none

Yusuke Suzuki
Reported 2016-10-04 10:21:19 PDT
[DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information
Attachments
Patch (37.41 KB, patch)
2016-10-04 10:40 PDT, Yusuke Suzuki 		fpizlo: review+
DetailsFormatted DiffDiff
Patch for landing (44.93 KB, patch)
2016-10-04 11:40 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch for landing (47.42 KB, patch)
2016-10-04 11:53 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch for landing (48.08 KB, patch)
2016-10-04 12:04 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2016-10-04 10:40:41 PDT
Created attachment 290614 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-04 10:42:22 PDT
Attachment 290614 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.cpp:46: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2016-10-04 11:02:04 PDT
Comment on attachment 290614 [details] Patch This is awesome! please make the bots happy. Hopefully it's not a serious bug.
Yusuke Suzuki
Comment 4 2016-10-04 11:10:29 PDT
(In reply to comment #3) > Comment on attachment 290614 [details] > Patch > > This is awesome! please make the bots happy. Hopefully it's not a serious > bug. Thanks! It seems that CCallHelpers is not export-to-WebCore ready (Oh, it includes DFGMinifiedID.h!). I'll soon fix this issue.
Filip Pizlo
Comment 5 2016-10-04 11:15:19 PDT
(In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 290614 [details] > > Patch > > > > This is awesome! please make the bots happy. Hopefully it's not a serious > > bug. > > Thanks! It seems that CCallHelpers is not export-to-WebCore ready (Oh, it > includes DFGMinifiedID.h!). I'll soon fix this issue. Crazy! Maybe we can break the dependency on MinifiedID. It doesn't seem to need it.
Filip Pizlo
Comment 6 2016-10-04 11:17:14 PDT
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > Comment on attachment 290614 [details] > > > Patch > > > > > > This is awesome! please make the bots happy. Hopefully it's not a serious > > > bug. > > > > Thanks! It seems that CCallHelpers is not export-to-WebCore ready (Oh, it > > includes DFGMinifiedID.h!). I'll soon fix this issue. > > Crazy! Maybe we can break the dependency on MinifiedID. It doesn't seem to > need it. Actually, DFGMinifiedID.h only includes DFGCommon.h, which is already exportable, so I guess it wouldn't be the end of the world if DFGMinifiedID.h was also made exportable.
Yusuke Suzuki
Comment 7 2016-10-04 11:38:43 PDT
(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (In reply to comment #3) > > > > Comment on attachment 290614 [details] > > > > Patch > > > > > > > > This is awesome! please make the bots happy. Hopefully it's not a serious > > > > bug. > > > > > > Thanks! It seems that CCallHelpers is not export-to-WebCore ready (Oh, it > > > includes DFGMinifiedID.h!). I'll soon fix this issue. > > > > Crazy! Maybe we can break the dependency on MinifiedID. It doesn't seem to > > need it. > > Actually, DFGMinifiedID.h only includes DFGCommon.h, which is already > exportable, so I guess it wouldn't be the end of the world if > DFGMinifiedID.h was also made exportable. OK, I've changed this attribute from Project to Private. And I also fixed CMake issue. Before landing, I'll see the patch's health in EWS.
Yusuke Suzuki
Comment 8 2016-10-04 11:40:11 PDT
Created attachment 290626 [details] Patch for landing
WebKit Commit Bot
Comment 9 2016-10-04 11:43:02 PDT
Attachment 290626 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.cpp:46: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 10 2016-10-04 11:53:42 PDT
Created attachment 290629 [details] Patch for landing Add more assembler/ headers. Some assembler/ headers were not included in any targets.
WebKit Commit Bot
Comment 11 2016-10-04 11:55:42 PDT
Attachment 290629 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.cpp:46: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 12 2016-10-04 12:04:01 PDT
Created attachment 290632 [details] Patch for landing Add more jit headers (generic data structures). Some assembler/ and jit/ headers were not included in any targets.
WebKit Commit Bot
Comment 13 2016-10-04 12:07:53 PDT
Attachment 290632 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.cpp:46: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 14 2016-10-04 12:37:22 PDT
Committed r206779: <http://trac.webkit.org/changeset/206779>
Note You need to log in before you can comment on or make changes to this bug.