Bug 180124

Summary: Web Inspector: Console Tab navigation bar sometimes does not include filter bar, clear console sometimes does not work
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix bburg: review+

Joseph Pecoraro
Reported 2017-11-28 20:15:39 PST
Console Tab navigation bar sometimes does not include filter bar Steps to Reproduce: 1. Inspect this page 2. Show Debugger tab 3. Show Split Console drawer 4. Show Console tab => Console doesn't have filter bar, but it should Notes: - There are navigation items that only toggle when in the console tab, but those are sometimes not showing because "isShowingSplitConsole" is still true.
Attachments
[PATCH] Proposed Fix (1.50 KB, patch)
2017-11-28 20:19 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (4.43 KB, patch)
2017-11-28 20:37 PST, Joseph Pecoraro 		bburg: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-11-28 20:19:32 PST
Created attachment 327822 [details] [PATCH] Proposed Fix
Matt Baker
Comment 2 2017-11-28 20:24:16 PST
Comment on attachment 327822 [details] [PATCH] Proposed Fix Nice fix, r=me
Joseph Pecoraro
Comment 3 2017-11-28 20:28:33 PST
Comment on attachment 327822 [details] [PATCH] Proposed Fix There are actually a host of issues here. While this is correct I'm going to expand on it all in one patch.
Radar WebKit Bug Importer
Comment 4 2017-11-28 20:36:47 PST
<rdar://problem/35740353>
Joseph Pecoraro
Comment 5 2017-11-28 20:37:38 PST
Created attachment 327823 [details] [PATCH] Proposed Fix
Blaze Burg
Comment 6 2017-11-29 09:41:51 PST
Comment on attachment 327823 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=327823&action=review r=me > Source/WebInspectorUI/ChangeLog:21 > + It is also now possible, to share a ContentView across ContentBrowsers via Nit: -,
Joseph Pecoraro
Comment 7 2017-11-29 11:07:46 PST
<https://trac.webkit.org/r225280>
Note You need to log in before you can comment on or make changes to this bug.