Bug 191165

Summary: Web Inspector: Styles: inline swatches don't work when Multiple Properties Selection is enabled
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
hi: review-
[Animated GIF] With patch applied
none
Patch none

Nikita Vasilyev
Reported 2018-11-01 12:24:30 PDT
Clicking on an inline swatch starts editing the property value instead of showing a popover (such as a color picker).
Attachments
Patch (3.74 KB, patch)
2018-11-10 18:33 PST, Nikita Vasilyev 		hi: review-
DetailsFormatted DiffDiff
[Animated GIF] With patch applied (131.26 KB, image/gif)
2018-11-10 18:33 PST, Nikita Vasilyev 		no flags
Details
Patch (4.35 KB, patch)
2018-11-11 20:02 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-01 12:24:49 PDT
<rdar://problem/45737972>
Nikita Vasilyev
Comment 2 2018-11-10 18:33:12 PST
Created attachment 354489 [details] Patch This was surprisingly tricky. I learned that "mouseup" always fires before "click".
Nikita Vasilyev
Comment 3 2018-11-10 18:33:41 PST
Created attachment 354490 [details] [Animated GIF] With patch applied
Devin Rousso
Comment 4 2018-11-11 17:27:01 PST
Comment on attachment 354489 [details] Patch r-, I am unable to click again after I've started editing (e.g. to move the cursor), as it tries to restart editing
Nikita Vasilyev
Comment 5 2018-11-11 19:52:32 PST
(In reply to Devin Rousso from comment #4) > Comment on attachment 354489 [details] > Patch > > r-, I am unable to click again after I've started editing (e.g. to move the > cursor), as it tries to restart editing This is actually a bug that wasn't introduced by this patch. Regardless, I can fix it here.
Nikita Vasilyev
Comment 6 2018-11-11 20:02:19 PST
Created attachment 354528 [details] Patch
Devin Rousso
Comment 7 2018-11-12 20:15:16 PST
Comment on attachment 354528 [details] Patch r=me, nice fix :)
WebKit Commit Bot
Comment 8 2018-11-12 20:43:49 PST
Comment on attachment 354528 [details] Patch Clearing flags on attachment: 354528 Committed r238120: <https://trac.webkit.org/changeset/238120>
WebKit Commit Bot
Comment 9 2018-11-12 20:43:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.