Bug 194437

Summary: REGRESSION (r240644): Layout Test inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky timeout
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: Tools / TestsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, jlewis3, joepeck, lforschler, ryanhaddad, sroberts, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Truitt Savell
Reported 2019-02-08 09:10:51 PST
The following layout test is flaky on Mojave inspector/page/overrideSetting-ICECandidateFilteringEnabled.html Probable cause: Test was introduced in https://trac.webkit.org/changeset/240644/webkit and is a flakey timeout. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fpage%2FoverrideSetting-ICECandidateFilteringEnabled.html
Attachments
Patch (3.75 KB, patch)
2019-02-27 17:58 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (5.19 KB, patch)
2019-04-09 12:11 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (3.06 KB, patch)
2019-05-13 11:32 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-02-12 11:24:52 PST
<rdar://problem/48008005>
Devin Rousso
Comment 2 2019-02-27 17:58:34 PST
Created attachment 363171 [details] Patch Not really sure why it's flaky, but I ran it a few hundred times on my machine (WK1 and WK2) and it seemed to work better
Joseph Pecoraro
Comment 3 2019-02-28 14:20:41 PST
Comment on attachment 363171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363171&action=review rs=me > LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:24 > + delete pc.onicecandidate; Just set it to null instead of delete?
WebKit Commit Bot
Comment 4 2019-02-28 14:54:43 PST
Comment on attachment 363171 [details] Patch Clearing flags on attachment: 363171 Committed r242231: <https://trac.webkit.org/changeset/242231>
WebKit Commit Bot
Comment 5 2019-02-28 14:54:45 PST
All reviewed patches have been landed. Closing bug.
Shawn Roberts
Comment 6 2019-03-21 17:06:30 PDT
This test is still timing out on Mojave WK1 about 1 in every 4 runs on the dashboard. Also is timing out on Mojave Wk2, but not nearly as consistently. Was able to reproduce locally with : run-webkit-tests inspector/page/overrideSetting-ICECandidateFilteringEnabled.html --iterations 500 -f -1 Produced 22 failures. run-webkit-tests inspector/page/overrideSetting-ICECandidateFilteringEnabled.html --iterations 500 -f Produced 9 failures. Flakiness Dashboard : https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fpage%2FoverrideSetting-ICECandidateFilteringEnabled.html
Ryan Haddad
Comment 7 2019-04-02 13:33:11 PDT
Reopening based on Shawn's comment above.
Devin Rousso
Comment 8 2019-04-09 12:11:22 PDT
Created attachment 367060 [details] Patch It seems like the main issue was with the first part of the test. Removing it made it pass without issue on 1000+ iterations on my machine. I've also enabled debug logging just in case it still fails so we can hopefully get more information as to why.
Joseph Pecoraro
Comment 9 2019-04-15 12:20:05 PDT
Comment on attachment 367060 [details] Patch r=me
WebKit Commit Bot
Comment 10 2019-04-15 12:46:40 PDT
Comment on attachment 367060 [details] Patch Clearing flags on attachment: 367060 Committed r244280: <https://trac.webkit.org/changeset/244280>
WebKit Commit Bot
Comment 11 2019-04-15 12:46:41 PDT
All reviewed patches have been landed. Closing bug.
Devin Rousso
Comment 13 2019-05-13 11:32:01 PDT
Created attachment 369754 [details] Patch It seems like the failure occurs after the first "part" of the test. Given that the second "part" doesn't really add anything new (e.g. the first "part" goes from filtering enabled to disabled, while the second "part" does the opposite), I think it's fine to remove.
Joseph Pecoraro
Comment 14 2019-05-15 15:09:23 PDT
Comment on attachment 369754 [details] Patch rs=me
WebKit Commit Bot
Comment 15 2019-05-15 15:37:18 PDT
Comment on attachment 369754 [details] Patch Clearing flags on attachment: 369754 Committed r245363: <https://trac.webkit.org/changeset/245363>
WebKit Commit Bot
Comment 16 2019-05-15 15:37:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.