Bug 198713

Summary: [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WPE WebKitAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, cgarcia, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cgarcia: review+

Philippe Normand
Reported 2019-06-10 06:37:40 PDT
Patch incoming
Attachments
Patch (6.63 KB, patch)
2019-06-10 06:40 PDT, Philippe Normand 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2019-06-10 06:40:25 PDT
Created attachment 371737 [details] Patch
Carlos Garcia Campos
Comment 2 2019-06-10 06:47:41 PDT
Comment on attachment 371737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371737&action=review > Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:212 > - RELEASE_ASSERT(m_lockedImage == EGL_NO_IMAGE_KHR); > + RELEASE_ASSERT(m_lockedImage == nullptr); !m_lockedImage > Source/cmake/OptionsWPE.cmake:175 > - pkg_check_modules(WPE_BACKEND_FDO REQUIRED wpebackend-fdo-1.0) > + pkg_check_modules(WPE_BACKEND_FDO REQUIRED "wpebackend-fdo-1.0 >= 1.3.0") Could you use find_package(WPEBackend-fdo 1.3.0) instead? You will have to change the INCLUDE_DIRS and LIBRARIES vars to WPEBACKEND_FDO_INCLUDE_DIRS and WPEBACKEND_FDO_LIBRARIES. That would make QtWPE consistent with wpe and gtk.
Philippe Normand
Comment 3 2019-06-10 07:05:47 PDT
Committed r246257: <https://trac.webkit.org/changeset/246257>
Adrian Perez
Comment 4 2019-06-10 07:12:00 PDT
*** Bug 198716 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.