Bug 201196

Summary: constructFunctionSkippingEvalEnabledCheck() should use tryMakeString() and check for OOM.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch. ysuzuki: review+

Mark Lam
Reported 2019-08-27 13:02:24 PDT
<rdar://problem/54703775>
Attachments
proposed patch. (2.81 KB, patch)
2019-08-27 13:05 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (3.59 KB, patch)
2019-08-27 13:07 PDT, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-08-27 13:05:11 PDT
Created attachment 377369 [details] proposed patch.
Mark Lam
Comment 2 2019-08-27 13:07:33 PDT
Created attachment 377371 [details] proposed patch.
Yusuke Suzuki
Comment 3 2019-08-27 13:08:58 PDT
Comment on attachment 377371 [details] proposed patch. r=me
Mark Lam
Comment 4 2019-08-27 13:11:21 PDT
Thanks for the review. Landed in r249164: <http://trac.webkit.org/r249164>.
Note You need to log in before you can comment on or make changes to this bug.