Bug 202955

Summary: results.webkit.org: Add os version to various unix ports
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, clopez, commit-queue, ews-watchlist, glenn, lingcherd_ho, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202928
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-10-14 14:41:57 PDT
Without an os_version, a port cannot upload test results.
Attachments
Patch (1.93 KB, patch)
2019-10-14 14:46 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.73 KB, patch)
2019-10-14 15:45 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.16 KB, patch)
2019-10-15 11:42 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-10-14 14:46:48 PDT
Created attachment 380922 [details] Patch
Jonathan Bedard
Comment 2 2019-10-14 15:45:45 PDT
Created attachment 380927 [details] Patch
Jonathan Bedard
Comment 3 2019-10-14 15:50:06 PDT
As per a discussion Carlos and I had in https://bugs.webkit.org/show_bug.cgi?id=202928, '#1 SMP Debian 4.19.37-5+deb10u2~bpo9+1 (2019-08-16)' (which is GTK's version) would have broken the original logic, so I changed it to a regex.
Aakash Jain
Comment 4 2019-10-15 11:16:24 PDT
Comment on attachment 380927 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380927&action=review rs=me > Tools/Scripts/webkitpy/common/system/platforminfo.py:69 > + self.os_version = Version.from_string(version.group(0)) should we log something in case version is not found?
Jonathan Bedard
Comment 5 2019-10-15 11:28:19 PDT
(In reply to Aakash Jain from comment #4) > Comment on attachment 380927 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380927&action=review > > rs=me > > > Tools/Scripts/webkitpy/common/system/platforminfo.py:69 > > + self.os_version = Version.from_string(version.group(0)) > > should we log something in case version is not found? Seems pretty reasonable to do that in the debug channel.
Jonathan Bedard
Comment 6 2019-10-15 11:42:49 PDT
Created attachment 381006 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-10-15 12:13:00 PDT
The commit-queue encountered the following flaky tests while processing attachment 381006 [details]: imported/w3c/web-platform-tests/content-security-policy/navigate-to/href-location-blocked.sub.html bug 203000 (author: dbates@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2019-10-15 12:13:42 PDT
Comment on attachment 381006 [details] Patch for landing Clearing flags on attachment: 381006 Committed r251150: <https://trac.webkit.org/changeset/251150>
WebKit Commit Bot
Comment 9 2019-10-15 12:13:44 PDT
All reviewed patches have been landed. Closing bug.
Ling Ho
Comment 10 2019-10-15 14:33:33 PDT
<rdar://problem/56302308>
Radar WebKit Bug Importer
Comment 11 2019-10-15 14:33:48 PDT
<rdar://problem/56308441>
Note You need to log in before you can comment on or make changes to this bug.