Bug 210890

Summary: Web Inspector: Uncaught Exception: SyntaxError: Invalid regular expression: missing )
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
URL: https://webkit.org/
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2020-04-22 18:24:06 PDT
Uncaught Exception in Web Inspector. # STEPS TO REPRODUCE 1. inspect any page 2. enable Search: Regular Expression in the General pane of the Settings Tab 3. go to the Sources Tab 4. enter "asd(" in the filter bar at the bottom of the navigation sidebar Uncaught Exceptions: ----------------------- - SyntaxError: Invalid regular expression: missing ) (at SearchUtilities.js:113:26) RegExp @ [native code] _regExpForString @ SearchUtilities.js:113:26 updateFilter @ NavigationSidebarPanel.js:320:88 _filterDidChange @ NavigationSidebarPanel.js:579:26 dispatch @ Object.js:165:30 dispatchEventToListeners @ Object.js:172:17 _handleFilterChanged @ FilterBar.js:183:42 _handleFilterChanged @ [native code] ----------------------- Notes: Inspected URL: https://webkit.org/ Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko)
Attachments
Patch (32.26 KB, patch)
2020-04-22 20:02 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-04-22 20:02:20 PDT
Created attachment 397307 [details] Patch
Blaze Burg
Comment 2 2020-04-23 12:33:51 PDT
Comment on attachment 397307 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397307&action=review r=me > Source/WebInspectorUI/ChangeLog:52 > + * UserInterface/Views/SearchBar.css: Removed. o_O > Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:463 > + let filterBar = this._filterBarNavigationItem.filterBar; Thank you for de-indenting this function.
EWS
Comment 3 2020-04-23 12:49:05 PDT
Committed r260589: <https://trac.webkit.org/changeset/260589> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397307 [details].
Radar WebKit Bug Importer
Comment 4 2020-04-23 12:50:33 PDT
<rdar://problem/62258087>
Note You need to log in before you can comment on or make changes to this bug.