Bug 216279

Summary: Fix precision issues in AudioParamTimeline when event times are very close
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-09-08 11:49:16 PDT
Fix precision issues in AudioParamTimeline when event times are very close.
Attachments
Patch (1.26 MB, patch)
2020-09-08 11:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.26 MB, patch)
2020-09-08 12:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.30 MB, patch)
2020-09-08 12:42 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-09-08 11:57:09 PDT
Created attachment 408250 [details] Patch
Darin Adler
Comment 2 2020-09-08 12:06:28 PDT
Comment on attachment 408250 [details] Patch I see that the code involves a lot of floating point division. Last time I checked, I believe floating point multiplication was significantly faster. Perhaps we can make some of this division be multiplication by calculating a reciprocal or by reorganizing expressions. Or perhaps this kind of micro-optimization thinking is not relevant to this code. r=me assuming the tests pass
Chris Dumez
Comment 3 2020-09-08 12:11:35 PDT
Created attachment 408252 [details] Patch
Chris Dumez
Comment 4 2020-09-08 12:42:59 PDT
Created attachment 408255 [details] Patch
EWS
Comment 5 2020-09-08 13:24:38 PDT
Committed r266746: <https://trac.webkit.org/changeset/266746> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408255 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-08 13:25:28 PDT
<rdar://problem/68526735>
Note You need to log in before you can comment on or make changes to this bug.