Bug 216625

Summary: Regression(r267144) 4 webaudio/oscillator tests are broken
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216569
Bug Depends on:    
Bug Blocks: 216569    
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2020-09-16 16:39:33 PDT
The following tests were added with https://trac.webkit.org/changeset/267144/webkit and appear to be missing expected results webaudio/oscillator-custom.html [ Missing ] webaudio/oscillator-sawtooth.html [ Missing ] webaudio/oscillator-square.html [ Missing ] webaudio/oscillator-triangle.html [ Missing ] https://build.webkit.org/results/Apple-Catalina-Release-WK1-Tests/r267166%20(9108)/results.html
Attachments
Patch (848.85 KB, patch)
2020-09-16 17:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-09-16 16:40:45 PDT
Will fix shortly.
Ryan Haddad
Comment 2 2020-09-16 16:52:43 PDT
I've got the change to add results, will land it now.
Ryan Haddad
Comment 3 2020-09-16 16:55:37 PDT
Fixed in r267171.
Radar WebKit Bug Importer
Comment 4 2020-09-16 16:56:21 PDT
<rdar://problem/69024624>
Ryan Haddad
Comment 5 2020-09-16 16:59:13 PDT
Reverted r267171 for reason: The tests need to be fixed Committed r267173: <https://trac.webkit.org/changeset/267173>
Chris Dumez
Comment 6 2020-09-16 17:16:53 PDT
Created attachment 408967 [details] Patch
EWS
Comment 7 2020-09-17 11:10:39 PDT
Committed r267201: <https://trac.webkit.org/changeset/267201> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408967 [details].
Note You need to log in before you can comment on or make changes to this bug.