Bug 222595

Summary: Animation from "scale()" to "scale() translate()" does not yield the expected result
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, kondapallykalyan, mrobinson, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 235757    
Attachments:
Description Flags
Test
none
Firefox
none
Safari
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Antoine Quint
Reported 2021-03-02 06:44:40 PST
Created attachment 421929 [details] Test The attached test runs the following animation: document.querySelector("div").animate({ transform: ["scale(2)", "scale(0.1) translateX(-200px)"] }, 1000); In Firefox and Chrome you can see the elements animate one way (see screen recording) and in Safari (after r273656, the fix for bug 222545) another way. We likely have the incorrect behavior.
Attachments
Test (340 bytes, text/html)
2021-03-02 06:44 PST, Antoine Quint 		no flags
Details
Firefox (494.75 KB, video/quicktime)
2021-03-02 06:45 PST, Antoine Quint 		no flags
Details
Safari (182.06 KB, video/quicktime)
2021-03-02 06:45 PST, Antoine Quint 		no flags
Details
Patch (31.42 KB, patch)
2022-02-08 08:15 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (49.88 KB, patch)
2022-02-08 10:03 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (53.11 KB, patch)
2022-02-09 06:42 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (60.74 KB, patch)
2022-02-11 05:00 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (53.81 KB, patch)
2022-02-14 03:17 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2021-03-02 06:45:02 PST
Created attachment 421930 [details] Firefox
Antoine Quint
Comment 2 2021-03-02 06:45:15 PST
Created attachment 421931 [details] Safari
Radar WebKit Bug Importer
Comment 3 2021-03-02 06:45:58 PST
<rdar://problem/74926700>
Antoine Quint
Comment 4 2021-03-02 07:02:52 PST
This is not a recent regression, at the very least this behavior was also observable in Safari 13 before Web Animations were supported, using a similar test with CSS Transitions.
Antoine Quint
Comment 5 2022-02-07 00:14:24 PST
Cc'ing Martin who's been looking at css-transforms issues recently.
Martin Robinson
Comment 6 2022-02-08 08:15:40 PST
Created attachment 451251 [details] Patch
Martin Robinson
Comment 7 2022-02-08 10:03:31 PST
Created attachment 451268 [details] Patch
Antoine Quint
Comment 8 2022-02-08 11:36:27 PST
Yes, this is working fine for me in STP 139 and Safari in macOS 12.3 Beta.
Antoine Quint
Comment 9 2022-02-08 11:36:53 PST
Oops, I commented on the wrong bug!
Martin Robinson
Comment 10 2022-02-09 00:34:10 PST
Comment on attachment 451268 [details] Patch Looks like this is hitting an assertion failure in an assertion that I added. I'm investigating this now. It also probably makes sense for this to land after the patch in bug 236116.
Martin Robinson
Comment 11 2022-02-09 06:42:37 PST
Created attachment 451368 [details] Patch
Martin Robinson
Comment 12 2022-02-11 05:00:44 PST
Created attachment 451676 [details] Patch
Martin Robinson
Comment 13 2022-02-14 03:17:12 PST
Created attachment 451879 [details] Patch
EWS
Comment 14 2022-02-14 06:04:21 PST
Committed r289732 (247217@main): <https://commits.webkit.org/247217@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451879 [details].
Antoine Quint
Comment 15 2022-02-14 06:22:45 PST
*** Bug 235804 has been marked as a duplicate of this bug. ***
Antoine Quint
Comment 16 2022-02-14 06:23:21 PST
*** Bug 235802 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.