Bug 224815

Summary: Fix isCSSWideKeyword to stop including `default`
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch ews-feeder: commit-queue-

Tim Nguyen (:ntim)
Reported 2021-04-20 08:41:55 PDT
I discovered that isCSSWideKeywords included CSSValueDefault, which was slightly surprising. Antti mentioned this was because `default` used to be the old name for `revert`. Since this is not supported in any browser, let's remove it.
Attachments
Patch (2.66 KB, patch)
2021-04-20 08:52 PDT, Tim Nguyen (:ntim) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (2.39 KB, patch)
2021-04-20 09:01 PDT, Tim Nguyen (:ntim) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-04-20 08:43:21 PDT
<rdar://problem/76900167>
Tim Nguyen (:ntim)
Comment 2 2021-04-20 08:52:43 PDT
Created attachment 426551 [details] Patch
Tim Nguyen (:ntim)
Comment 3 2021-04-20 09:01:54 PDT
Created attachment 426552 [details] Patch
Darin Adler
Comment 4 2021-04-25 10:35:43 PDT
I think it’s important to talk about the observable change we want in behavior rather than the internal function name. Do we have a test for the case where we end up handling "default" incorrectly? I still fully expect this will end up being a useful change once we understand why the tests we already have start indicating a failure and take care of that. We may need a different internal function to use where we are currently using isCSSWideKeyword.
Tim Nguyen (:ntim)
Comment 5 2021-11-06 09:08:31 PDT
*** This bug has been marked as a duplicate of bug 232750 ***
Note You need to log in before you can comment on or make changes to this bug.