Bug 227275

Summary: [WebIDL] Rework runtime enabled properties leveraging PropertyCallback
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: REOPENED    
Severity: Normal CC: alecflett, beidson, cdumez, commit-queue, esprehn+autocc, ews-watchlist, jsbell, keith_miller, kondapallykalyan, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 227732    
Bug Blocks: 158557, 227668, 227672, 227673    
Attachments:
Description Flags
Patch none

Alexey Shvayka
Reported 2021-06-22 19:01:15 PDT
This approach preserves HashTable's immutability while avoiding addition of extra checks to entry lookup and memory usage increase. Enables removal of eager property reification in a follow-up change.
Attachments
Patch (807.57 KB, patch)
2021-07-02 12:21 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-06-29 19:02:15 PDT
<rdar://problem/79944793>
Alexey Shvayka
Comment 2 2021-07-02 12:21:27 PDT
Created attachment 432811 [details] Patch
Alexey Shvayka
Comment 3 2021-07-03 12:30:36 PDT
Comment on attachment 432811 [details] Patch This was already reviewed in https://bugs.webkit.org/show_bug.cgi?id=158557#c40, and should be safe (in terms of performance & web-compat) to land.
EWS
Comment 4 2021-07-03 12:57:57 PDT
Committed r279546 (239382@main): <https://commits.webkit.org/239382@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432811 [details].
Yusuke Suzuki
Comment 5 2021-07-06 19:50:09 PDT
This caused 2-3% regression in Speedometer/jQuery-TodoMVC on M1 macOS (not sure whether this is in Intel macOS).
WebKit Commit Bot
Comment 6 2021-07-06 20:09:33 PDT
Re-opened since this is blocked by bug 227732
Note You need to log in before you can comment on or make changes to this bug.