Bug 227668

Summary: [WebIDL] Generate constructor's hash table in GenerateConstructorHelperMethods
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: BindingsAssignee: Alexey Shvayka <ashvayka>
Status: REOPENED    
Severity: Enhancement CC: cdumez, commit-queue, darin, ews-watchlist, sam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 227275, 227732    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Alexey Shvayka
Reported 2021-07-03 15:35:08 PDT
[WebIDL] Generate constructor's hash table in GenerateConstructorHelperMethods
Attachments
Patch (22.28 KB, patch)
2021-07-03 15:37 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2021-07-03 15:37:44 PDT
Created attachment 432857 [details] Patch
Alexey Shvayka
Comment 2 2021-07-04 11:27:44 PDT
Comment on attachment 432857 [details] Patch Thank you for reviews, Sam!
EWS
Comment 3 2021-07-04 11:38:03 PDT
Committed r279554 (239388@main): <https://commits.webkit.org/239388@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432857 [details].
Radar WebKit Bug Importer
Comment 4 2021-07-04 11:39:17 PDT
<rdar://problem/80153102>
WebKit Commit Bot
Comment 5 2021-07-06 20:09:35 PDT
Re-opened since this is blocked by bug 227732
Yusuke Suzuki
Comment 6 2021-07-06 20:11:20 PDT
https://trac.webkit.org/changeset/279546/webkit caused 2-3% regression in Speedometer2/jQuery-TodoMVC and it was hard to revert r279546 without reverting this change. Please reland this without r279546 change, thanks!
Note You need to log in before you can comment on or make changes to this bug.