Bug 228546

Summary: CSS cleanup: Convert -webkit prefixed CSS Logical properties to standard properties
Product: WebKit Reporter: Sonia Singla <soniasingla.1812>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: fred.wang, gsnedders, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 228548, 228697, 228730    
Bug Blocks:    
Attachments:
Description Flags
List of current usage outside of benchmarks and LayoutTests none

Sonia Singla
Reported 2021-07-28 04:28:54 PDT
In WebKit, some internal stylesheets use the legacy -webkit prefixed CSS Logical properties (e.g. https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-border-before ). Should instead replace them with the equivalent standard versions (e.g. https://developer.mozilla.org/en-US/docs/Web/CSS/border-block-start ). Probably we can convert it into a meta bug.
Attachments
List of current usage outside of benchmarks and LayoutTests (10.77 KB, text/plain)
2021-07-30 06:31 PDT, Sam Sneddon [:gsnedders] 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2021-07-30 06:31:04 PDT
Created attachment 434618 [details] List of current usage outside of benchmarks and LayoutTests There isn't that much in way of usage from the look of it, practically all of it been within the UA stylesheets, which should be easy to change if anyone wants to.
Frédéric Wang (:fredw)
Comment 2 2021-08-02 02:01:30 PDT
(In reply to Sam Sneddon [:gsnedders] from comment #1) > Created attachment 434618 [details] > List of current usage outside of benchmarks and LayoutTests > > There isn't that much in way of usage from the look of it, practically all > of it been within the UA stylesheets, which should be easy to change if > anyone wants to. Thanks Sam. Yes, that matches what Sonia found. The ones in CSSProperties.json should be kept as long as we continue to support legacy names. I think the proposal was to split the work like this: (1) Replace those related to CSS completion (bug 228548) -- it was commented there that ContextualDocumentationDatabase.js (and Jetstream benchmarks) can be ignored. (2) Replace those in internal CSS stylesheets. (3) Replace those in internal LayoutTests (that should be safe unless they test specifically legacy names). It seems there are more in imported WPT tests, but it's just because they have not been synchronized with upstream WPT.
Radar WebKit Bug Importer
Comment 3 2021-08-04 04:29:15 PDT
<rdar://problem/81508886>
Note You need to log in before you can comment on or make changes to this bug.