Bug 230598

Summary: Make sure empty font families do the right thing for font palettes
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, mmaxfield, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 230446    
Attachments:
Description Flags
Patch thorton: review+, mmaxfield: commit-queue+

Myles C. Maxfield
Reported 2021-09-21 22:24:49 PDT
Make sure empty font families do the right thing for font palettes
Attachments
Patch (5.45 KB, patch)
2021-09-24 22:29 PDT, Myles C. Maxfield 		thorton: review+
mmaxfield: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-09-21 22:25:16 PDT
<rdar://problem/83383955>
Myles C. Maxfield
Comment 2 2021-09-24 00:44:39 PDT
It should do the right thing, because no element can have a font family of "". I should write a test to do this. This should be a part of https://github.com/web-platform-tests/wpt/pull/30910.
Myles C. Maxfield
Comment 3 2021-09-24 22:29:29 PDT
Created attachment 439236 [details] Patch
EWS Watchlist
Comment 4 2021-09-24 22:30:37 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Myles C. Maxfield
Comment 5 2021-09-25 00:16:31 PDT
Committed r283075 (242133@main): <https://commits.webkit.org/242133@main>
Note You need to log in before you can comment on or make changes to this bug.