Bug 232236

Summary: [CSS Cascade Layers] Support 'revert-layer' value
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, ntim, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 232829, 232875, 232876, 234674    
Bug Blocks: 220779, 234646    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch
none
Patch none

Antti Koivisto
Reported 2021-10-25 06:32:31 PDT
https://www.w3.org/TR/css-cascade-5/#revert-layer
Attachments
Patch (34.10 KB, patch)
2021-11-08 05:45 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (34.81 KB, patch)
2021-11-08 08:37 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (37.24 KB, patch)
2021-11-09 00:45 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (36.57 KB, patch)
2021-11-11 01:29 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (38.85 KB, patch)
2021-11-11 01:44 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-01 06:33:17 PDT
<rdar://problem/84879369>
Antti Koivisto
Comment 2 2021-11-08 05:45:21 PST
Created attachment 443534 [details] Patch
Simon Fraser (smfr)
Comment 3 2021-11-08 08:27:12 PST
Comment on attachment 443534 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443534&action=review > Source/WebCore/style/CascadeLevel.h:39 > +inline CascadeLevel& operator--(CascadeLevel& level) I wonder if it's worth giving this an explicit name. > Source/WebCore/style/ElementRuleCollector.h:69 > +enum class FromStyleAttribute { No, Yes }; : bool ?
Antti Koivisto
Comment 4 2021-11-08 08:37:41 PST
Created attachment 443551 [details] Patch for landing
EWS
Comment 5 2021-11-08 09:21:03 PST
Committed r285408 (243965@main): <https://commits.webkit.org/243965@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443551 [details].
WebKit Commit Bot
Comment 6 2021-11-08 11:55:13 PST
Re-opened since this is blocked by bug 232829
Antti Koivisto
Comment 7 2021-11-09 00:45:27 PST
Created attachment 443658 [details] Patch for landing
EWS
Comment 8 2021-11-09 01:29:50 PST
Committed r285486 (244010@main): <https://commits.webkit.org/244010@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443658 [details].
WebKit Commit Bot
Comment 9 2021-11-09 05:49:55 PST
Re-opened since this is blocked by bug 232875
Antti Koivisto
Comment 10 2021-11-09 06:02:49 PST
Reverted in https://bugs.webkit.org/show_bug.cgi?id=232876
Tim Nguyen (:ntim)
Comment 11 2021-11-09 09:20:11 PST
You probably want to re-apply https://github.com/WebKit/WebKit/commit/573122828aba14874cd08c2fab0f2e8e169345cd after once you land again.
Antti Koivisto
Comment 12 2021-11-11 01:29:07 PST
Created attachment 443920 [details] Patch
Antti Koivisto
Comment 13 2021-11-11 01:44:07 PST
Created attachment 443921 [details] Patch
EWS
Comment 14 2021-11-11 04:24:24 PST
Committed r285624 (244125@main): <https://commits.webkit.org/244125@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443921 [details].
Note You need to log in before you can comment on or make changes to this bug.