Bug 233994

Summary: GraphicsContextGLANGLE delivers context lost twice when reshape fails
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: ASSIGNED    
Severity: Normal CC: cmarcelo, dino, ews-watchlist, kbr, kkinnunen, koivisto, kondapallykalyan, luiz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 221664    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch for EWS ews-feeder: commit-queue-

Kimmo Kinnunen
Reported 2021-12-08 01:43:22 PST
GraphicsContextGLANGLE delivers context lost twice when reshape fails
Attachments
Patch (10.78 KB, patch)
2021-12-08 01:51 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.75 KB, patch)
2021-12-08 02:09 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.15 KB, patch)
2021-12-08 03:17 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for EWS (18.20 KB, patch)
2021-12-08 12:16 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-12-08 01:51:07 PST
Created attachment 446334 [details] Patch
Antti Koivisto
Comment 2 2021-12-08 01:56:14 PST
Comment on attachment 446334 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446334&action=review > Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:387 > + // Returns true on success. > bool reshapeFBOs(const IntSize&); enum class return type would requires less explanations > Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:400 > - // Returns false if context should be lost due to timeout. > + // Returns true on success. Returns false if context should be lost due to timeout. > bool waitAndUpdateOldestFrame() WARN_UNUSED_RETURN; here too
Kimmo Kinnunen
Comment 3 2021-12-08 02:09:02 PST
Created attachment 446337 [details] Patch for landing
Kimmo Kinnunen
Comment 4 2021-12-08 03:17:37 PST
Created attachment 446345 [details] Patch for landing
Kimmo Kinnunen
Comment 5 2021-12-08 12:16:45 PST
Created attachment 446408 [details] Patch for EWS
Radar WebKit Bug Importer
Comment 6 2021-12-15 01:44:18 PST
<rdar://problem/86512404>
Note You need to log in before you can comment on or make changes to this bug.