Bug 235685

Summary:

Add fuzzy match data to WPT

Product:

WebKit

Reporter:

Jon Lee <jonlee>

Component:

Tools / Tests

Assignee:

Jon Lee <jonlee>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

clopez, darin, ews-watchlist, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://github.com/web-platform-tests/wpt/pull/32692

Bug Depends on:

Bug Blocks:

231828

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Jon Lee

Reported 2022-01-26 20:42:21 PST

Attachments
Patch (66.05 KB, patch) 2022-01-27 00:36 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (66.05 KB, patch) 2022-01-27 00:58 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (66.02 KB, patch) 2022-01-27 09:46 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (69.15 KB, patch) 2022-01-28 17:45 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (64.25 KB, patch) 2022-02-03 23:24 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (64.25 KB, patch) 2022-02-03 23:30 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (64.25 KB, patch) 2022-02-03 23:32 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (64.25 KB, patch) 2022-02-03 23:33 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (64.25 KB, patch) 2022-02-03 23:36 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (64.25 KB, patch) 2022-02-03 23:38 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (64.25 KB, patch) 2022-02-03 23:41 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (64.25 KB, patch) 2022-02-03 23:41 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (64.25 KB, patch) 2022-02-03 23:44 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (64.25 KB, patch) 2022-02-03 23:45 PST, Jon Lee	no flags	Details Formatted Diff Diff
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.

Jon Lee

Comment 1 2022-01-27 00:36:29 PST

Created attachment 450108 [details] Patch

EWS Watchlist

Comment 2 2022-01-27 00:38:14 PST

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Jon Lee

Comment 3 2022-01-27 00:58:35 PST

Created attachment 450113 [details] Patch

Jon Lee

Comment 4 2022-01-27 09:46:14 PST

Created attachment 450148 [details] Patch

Darin Adler

Comment 5 2022-01-28 10:56:57 PST

Comment on attachment 450148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450148&action=review > LayoutTests/imported/w3c/ChangeLog:3 > + Add fuzzy match data to WPT How will upstreaming of this work? Is this cross-platform setting that we all have to agree on? Will this be obliterated when we update to newer versions of WPT?

Darin Adler

Comment 6 2022-01-28 10:57:22 PST

Comment on attachment 450148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450148&action=review >> LayoutTests/imported/w3c/ChangeLog:3 >> + Add fuzzy match data to WPT > > How will upstreaming of this work? Is this cross-platform setting that we all have to agree on? Will this be obliterated when we update to newer versions of WPT? I meant "a cross-browser setting"

Jon Lee

Comment 7 2022-01-28 12:02:33 PST

(In reply to Darin Adler from comment #5) > Comment on attachment 450148 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450148&action=review > > > LayoutTests/imported/w3c/ChangeLog:3 > > + Add fuzzy match data to WPT > > How will upstreaming of this work? Is this cross-platform setting that we > all have to agree on? Will this be obliterated when we update to newer > versions of WPT? I'm going to adjust the close tags for some of these tests, but as part of it will begin the process of upstreaming the changes. It is a cross-browser setting that everyone needs to agree on, hence the 0 lower bound.

Jon Lee

Comment 8 2022-01-28 12:03:03 PST

(In reply to Jon Lee from comment #7) > I'm going to adjust the close tags for some of these tests, but as part of > it will begin the process of upstreaming the changes. Meaning I'm going to upload a new patch.

Jon Lee

Comment 9 2022-01-28 17:45:06 PST

Created attachment 450296 [details] Patch

Radar WebKit Bug Importer

Comment 10 2022-02-02 20:43:18 PST

<rdar://problem/88416387>

Darin Adler

Comment 11 2022-02-03 04:29:00 PST

Comment on attachment 450296 [details] Patch Need a rebased patch

Jon Lee

Comment 12 2022-02-03 22:58:22 PST

Committed r289105 (?): <https://commits.webkit.org/r289105>