Bug 239771
| Summary: | Block all direct pushes to GitHub | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jbedard, mcatanzaro, webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Michael Catanzaro
Today I accidentally pushed a sidebranch the main repo instead of my personal fork. We should block this from happening since we want people to create pull requests only from forks.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yusuke Suzuki
It is good if we can avoid creating a branch in the upstream repository.
Michael Catanzaro
Caveat: we probably do want to allow pushing to stable branches (including creating new branches) webkit-* and safari-*-branch.
Radar WebKit Bug Importer
<rdar://problem/92669177>
Jonathan Bedard
I've prevented pushes to:
eng/*
dev/*
bug/*
Additionally, we have branch protections on:
main
safari-*-branch
Happy to add more, but I also don't want to hamper folks ability to use feature branches, if we feel that is useful.