Bug 251157
| Summary: | [REGRESSION] Unauthenticated request to list PR files triggering rate-limits | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=246323 https://bugs.webkit.org/show_bug.cgi?id=250714 |
||
Aakash Jain
JSC queues are not skipping some non-relevant PRs.
e.g.:
https://ews-build.webkit.org/#/builders/1/builds/94597
https://ews-build.webkit.org/#/builders/1/builds/94551
https://ews-build.webkit.org/#/builders/1/builds/94604
https://ews-build.webkit.org/#/builders/1/builds/94595
https://ews-build.webkit.org/#/builders/1/builds/94593
https://ews-build.webkit.org/#/builders/1/builds/94589
https://ews-build.webkit.org/#/builders/1/builds/94587
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Aakash Jain
Example of recent build in which the logic worked fine: https://ews-build.webkit.org/#/builders/1/builds/94523
In this "check-change-relevance" step says: "Pull request doesn't have relevant changes" and the 'stdio' log say: "This pull request does not have relevant changes."
Aakash Jain
In the non-working build https://ews-build.webkit.org/#/builders/1/builds/94597, check-change-relevance step says: "Pull request contains relevant changes", and no 'stdio' log.
IN this build from Jan 13, when "check-change-relevance" said "Pull request contains relevant changes", there was also 'stdio' log saying: "This pull request contains relevant changes.": https://ews-build.webkit.org/#/builders/1/builds/93414
Missing 'stdio' log indicate that in CheckChangeRelevance.start() self._get_patch() returned empty patch triggering this code path for early exit (without any 'stdio' log): https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/ews-build/steps.py#L1211
_get_patch() method was recently changed on Jan 19 in https://commits.webkit.org/259088@main
Aakash Jain
For non-working build https://ews-build.webkit.org/#/builders/1/builds/94597, https://ews-build.webkit.org/api/v2/sourcestamps/740172/changes shows that the files in sourcestamp was empty [].
However, for old working build https://ews-build.webkit.org/#/builders/1/builds/93414, https://ews-build.webkit.org/api/v2/sourcestamps/736612/changes shows that the files in sourcestamp was non-empty.
Also, the logs on server have this:
twistd.log.1:2023-01-25 09:39:38-0800 [HTTP11ClientProtocol (TLSMemoryBIOProtocol),client] Failed fetching files for PR #9083: response code 400
Aakash Jain
Seems like a regression from https://commits.webkit.org/259282@main (Bug 250714)
Jonathan Bedard
We aren't fetching files with auth, that's the problem, silly mistake, easy fix.
Aakash Jain
This is happening on multiple queues including WebkitPy (e.g.: https://ews-build.webkit.org/#/builders/5/builds/108210), Services-EWS (e.g.: https://ews-build.webkit.org/#/builders/20/builds/103549) etc.
Radar WebKit Bug Importer
<rdar://problem/104659979>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/9141
EWS
Committed 259382@main (42ad013f55b2): <https://commits.webkit.org/259382@main>
Reviewed commits have been landed. Closing PR #9141 and removing active labels.
Jonathan Bedard
Re-opening for pull request https://github.com/WebKit/WebKit/pull/9149
EWS
Committed 259386@main (c54b1f4645fb): <https://commits.webkit.org/259386@main>
Reviewed commits have been landed. Closing PR #9149 and removing active labels.