Bug 260283
| Summary: | Remove LocalResourceHeap and QualifiedResourceHeap | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 260181 | ||
Said Abou-Hallawa
LocalResourceHeap is the only super class of ResourceHeap so it is cleaner to move all the implementation of LocalResourceHeap to ResourceHeap.
All the calls to the add() and get() functions of QualifiedResourceHeap come from RemoteRenderingBackend and RemoteDisplayListRecorder via RemoteResourceCache. These two callers qualify the RenderingResourceIdentifier with m_gpuConnectionToWebProcess->webProcessIdentifier() of the RemoteRenderingBackend.
But RemoteRenderingBackend never changes its m_gpuConnectionToWebProcess since it is defined to be `Ref<GPUConnectionToWebProcess>`. And GPUConnectionToWebProcess never changes its m_webProcessIdentifier since it is defined to be `const WebCore::ProcessIdentifier`. So the resources stored by QualifiedResourceHeap should have the same ProcessIdentifier.
This will make replaying a whole DisplayList in GPU Process be straightforward once the DisplayList items and the resources are transferred from Web Content Process to the GPU Process. The DisplayList::Replayer can be initialized with the decoded DisplayList items and the ResourceHeap of the RemoteResourceCache.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/113983207>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/16760
EWS
Committed 267044@main (d5ada78e4261): <https://commits.webkit.org/267044@main>
Reviewed commits have been landed. Closing PR #16760 and removing active labels.