Bug 282095
| Summary: | [GTK] Use std::array and ASCIILiteral in DropTargetGtk4.cpp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | WebKitGTK | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=281667 https://bugs.webkit.org/show_bug.cgi?id=282170 |
||
| Bug Depends on: | 281571 | ||
| Bug Blocks: | |||
Adrian Perez
We could use std::array in the constant arrays in holding MIME type
strings in Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp; to try
and to remove WTF_ALLOW_UNSAFE_BUFFER_USAGE_{BEGIN,END} usage.
While at it, each item in these arrays could be an ASCIILiteral to
avoid using GLib functions like g_strv_contains() that don't do
bounds checking.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/35720
EWS
Committed 285713@main (3f563ed0bcbf): <https://commits.webkit.org/285713@main>
Reviewed commits have been landed. Closing PR #35720 and removing active labels.