Bug 32124

Summary: [Qt] Debug version of DumpRenderTree crashes
Product: WebKit Reporter: Chang Shu <cshu>
Component: Tools / TestsAssignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Blocker CC: commit-queue, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
fix patch
none
a better fix none

Chang Shu
Reported 2009-12-03 10:34:55 PST
I was running the debug version of DumpRenderTree to debug some layout tests. But it crashed every time. The core dump is related to the following code in LayoutTestControllerQt.cpp: void LayoutTestController::maybeDump(bool success) { Q_ASSERT(sender() == m_topLoadingFrame); ...
Attachments
fix patch (1.21 KB, patch)
2009-12-03 10:37 PST, Chang Shu 		no flags
DetailsFormatted DiffDiff
a better fix (1.21 KB, patch)
2009-12-03 11:05 PST, Chang Shu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 2009-12-03 10:37:24 PST
Created attachment 44256 [details] fix patch I have to fix it as it blocked my work.
WebKit Review Bot
Comment 2 2009-12-03 10:42:07 PST
style-queue ran check-webkit-style on attachment 44256 [details] without any errors.
Chang Shu
Comment 3 2009-12-03 11:05:29 PST
Created attachment 44257 [details] a better fix Checking against the right object in assertion is better than removing it completely.
WebKit Review Bot
Comment 4 2009-12-03 11:07:47 PST
style-queue ran check-webkit-style on attachment 44257 [details] without any errors.
WebKit Commit Bot
Comment 5 2009-12-03 14:08:29 PST
Comment on attachment 44257 [details] a better fix Clearing flags on attachment: 44257 Committed r51662: <http://trac.webkit.org/changeset/51662>
WebKit Commit Bot
Comment 6 2009-12-03 14:08:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.