Bug 58477

Summary: REGRESSION(r83397) [Qt] When clicking on the media elements they grow 2 pixels.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: commit-queue, dglazkov, eric.carlson, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 52030    
Attachments:
Description Flags
Proposed patch.
none
Proposed patch V2 with Changelog fixed.
none
Proposed patch after breakage of Chromium. none

Alexis Menard (darktears)
Reported 2011-04-13 14:16:47 PDT
With the Qt port, on all platforms, Qt has a custom stylesheet for the mediacontrols, extending the default one. Clicking on the play button make it grow by 2px. Since r83397 the media controls elements are actual DOM elements. Therefore the global style-sheet applies to them. html.css defines input[type="button"]:active to be border-style: inset which means that when the buttons are active they grow by their border size.
Attachments
Proposed patch. (4.93 KB, patch)
2011-04-13 14:17 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Proposed patch V2 with Changelog fixed. (4.99 KB, patch)
2011-04-13 14:21 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Proposed patch after breakage of Chromium. (6.32 KB, patch)
2011-04-14 14:39 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2011-04-13 14:17:37 PDT
Created attachment 89454 [details] Proposed patch.
WebKit Review Bot
Comment 2 2011-04-13 14:19:56 PDT
Attachment 89454 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexis Menard (darktears)
Comment 3 2011-04-13 14:21:38 PDT
Created attachment 89458 [details] Proposed patch V2 with Changelog fixed.
Dimitri Glazkov (Google)
Comment 4 2011-04-13 14:44:43 PDT
Comment on attachment 89458 [details] Proposed patch V2 with Changelog fixed. Excellent fix. This takes care of "jiggling" buttons when you click on them.
WebKit Commit Bot
Comment 5 2011-04-14 06:19:52 PDT
The commit-queue encountered the following flaky tests while processing attachment 89458 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-04-14 06:22:35 PDT
Comment on attachment 89458 [details] Proposed patch V2 with Changelog fixed. Clearing flags on attachment: 89458 Committed r83847: <http://trac.webkit.org/changeset/83847>
WebKit Commit Bot
Comment 7 2011-04-14 06:22:39 PDT
All reviewed patches have been landed. Closing bug.
Dimitri Glazkov (Google)
Comment 8 2011-04-14 08:04:31 PDT
Turns out this change was wrong. Chromium port does use borders. So this change needs to go deeper into mediaControlsQt and mediaControlsQuickTime. Let's roll this out.
Dimitri Glazkov (Google)
Comment 9 2011-04-14 08:23:45 PDT
Reverted r83847 for reason: Chromium media controls do use button borders, so this change is incorrect. Committed r83858: <http://trac.webkit.org/changeset/83858>
Alexis Menard (darktears)
Comment 10 2011-04-14 14:39:56 PDT
Created attachment 89652 [details] Proposed patch after breakage of Chromium. We need to disable borders only in ports which are not using them :D.
WebKit Commit Bot
Comment 11 2011-04-15 07:35:11 PDT
The commit-queue encountered the following flaky tests while processing attachment 89652 [details]: http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async.html bug 58663 (authors: ap@webkit.org and sam@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 12 2011-04-15 07:38:53 PDT
Comment on attachment 89652 [details] Proposed patch after breakage of Chromium. Clearing flags on attachment: 89652 Committed r83973: <http://trac.webkit.org/changeset/83973>
WebKit Commit Bot
Comment 13 2011-04-15 07:38:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.