Bug 95374

Summary: [chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: aelias, cc-bugs, enne, jamesr, piman, webkit.review.bot, wjmaclean
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94145, 95871    
Attachments:
Description Flags
Patch
none
Patch for landing none

Dana Jansens
Reported 2012-08-29 13:48:16 PDT
[chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
Attachments
Patch (18.81 KB, patch)
2012-08-29 15:19 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.76 KB, patch)
2012-09-05 12:47 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-08-29 15:19:31 PDT
Created attachment 161329 [details] Patch
Adrienne Walker
Comment 2 2012-09-05 09:14:14 PDT
Comment on attachment 161329 [details] Patch R=me.
WebKit Review Bot
Comment 3 2012-09-05 11:11:58 PDT
Comment on attachment 161329 [details] Patch Rejecting attachment 161329 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /WebKit/chromium/tests/CCDrawQuadTest.cpp: In member function 'virtual void<unnamed>::CCDrawQuadTest_copyTileDrawQuad_Test::TestBody()': Source/WebKit/chromium/tests/CCDrawQuadTest.cpp:273: error: 'EXPECT_INT_RECT_EQ' was not declared in this scope CXX(target) out/Release/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/CCLayerImplTest.o make: *** [out/Release/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/CCDrawQuadTest.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/13746955
James Robinson
Comment 4 2012-09-05 11:20:34 PDT
The macro you want is gone - use EXPECT_RECT_EQ(). I'm surprised EWS is green - methinks it didn't actually process the patch as rigorously as the bubble would imply.....
James Robinson
Comment 5 2012-09-05 11:20:47 PDT
Or perhaps it ran before that rename.
Dana Jansens
Comment 6 2012-09-05 12:35:10 PDT
(In reply to comment #4) > The macro you want is gone - use EXPECT_RECT_EQ(). I'm surprised EWS is green - methinks it didn't actually process the patch as rigorously as the bubble would imply..... Oh okay, thanks.
Dana Jansens
Comment 7 2012-09-05 12:47:17 PDT
Created attachment 162308 [details] Patch for landing
WebKit Review Bot
Comment 8 2012-09-05 23:26:28 PDT
Comment on attachment 162308 [details] Patch for landing Clearing flags on attachment: 162308 Committed r127699: <http://trac.webkit.org/changeset/127699>
WebKit Review Bot
Comment 9 2012-09-05 23:26:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.