Bug 96853

Summary: [chromium] DumpRenderTree support for software compositing
Product: WebKit Reporter: Alexandre Elias <aelias>
Component: New BugsAssignee: Alexandre Elias <aelias>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, dglazkov, dpranke, enne, jamesr, ojan, peter+ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 96851    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Alexandre Elias
Reported 2012-09-14 20:19:22 PDT
[chromium] DumpRenderTree support for software compositing
Attachments
Patch (32.24 KB, patch)
2012-09-14 20:28 PDT, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Patch (26.34 KB, patch)
2012-09-17 15:46 PDT, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Patch (40.91 KB, patch)
2012-09-21 19:43 PDT, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Patch (41.84 KB, patch)
2012-09-24 14:48 PDT, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Patch (40.88 KB, patch)
2012-09-27 16:56 PDT, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alexandre Elias
Comment 1 2012-09-14 20:28:35 PDT
Created attachment 164271 [details] Patch
Alexandre Elias
Comment 2 2012-09-14 20:29:41 PDT
The expectations need some triage and bugs filed for them. I'll do that before landing.
WebKit Review Bot
Comment 3 2012-09-14 20:31:48 PDT
Comment on attachment 164271 [details] Patch Attachment 164271 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13844897
Peter Beverloo (cr-android ews)
Comment 4 2012-09-14 20:45:06 PDT
Comment on attachment 164271 [details] Patch Attachment 164271 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13860253
James Robinson
Comment 5 2012-09-16 21:52:18 PDT
Comment on attachment 164271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164271&action=review > LayoutTests/ChangeLog:18 > +2012-09-14 Alexandre Elias <aelias@chromium.org> double changelogs > LayoutTests/platform/chromium/TestExpectations:3621 > +// Render surfaces do not draw anything in the software compositor. > +WONTFIX SKIP : platform/chromium/virtual/softwarecompositing/backface-visibility/backface-visibility-hierarchical-transform.html = IMAGE is this really a WONTFIX? are we just going to not render reflections, etc?
Adrienne Walker
Comment 6 2012-09-17 12:41:37 PDT
Comment on attachment 164271 [details] Patch Just FYI, you can skip entire directories in TestExpectations, e.g. WONTFIX SKIP : platform/chromium/virtual/softwarecompositing/reflections = IMAGE
Alexandre Elias
Comment 7 2012-09-17 15:46:29 PDT
Created attachment 164466 [details] Patch Updated OutputDevice API and associated expectations with crbugs
Alexandre Elias
Comment 8 2012-09-21 19:43:58 PDT
Created attachment 165240 [details] Patch Switch to new TestExpectations format and do some triage
Alexandre Elias
Comment 9 2012-09-24 14:48:02 PDT
Created attachment 165451 [details] Patch Assign bugs to all the failing tests
Alexandre Elias
Comment 10 2012-09-24 14:49:48 PDT
PTAL; this is getting more polished-looking and the Chromium-side patches have landed.
James Robinson
Comment 11 2012-09-27 00:24:36 PDT
Comment on attachment 165451 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165451&action=review R=me very nice. Sorry I left this slip through the cracks for so long. > Tools/DumpRenderTree/chromium/WebViewHost.cpp:292 > +WebCompositorOutputSurface* WebViewHost::createOutputSurface() ah, there's a using namespace WebKit declaration in this file that I missed. How embarrassing! > Tools/DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp:51 > + if (m_device.get() && size.width == m_device->width() && size.height == m_device->height()) you can just say "if (m_device &&" and let OwnPtr<T>::operator bool() do the rest
Alexandre Elias
Comment 12 2012-09-27 16:56:33 PDT
Created attachment 166097 [details] Patch Rebase and remove .get()
WebKit Review Bot
Comment 13 2012-09-27 17:46:37 PDT
Comment on attachment 166097 [details] Patch Clearing flags on attachment: 166097 Committed r129826: <http://trac.webkit.org/changeset/129826>
WebKit Review Bot
Comment 14 2012-09-27 17:46:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.