RESOLVED FIXED130042
Web Inspector: console error when clicking AppCache folder tree element 
https://bugs.webkit.org/show_bug.cgi?id=130042
Summary Web Inspector: console error when clicking AppCache folder tree element
Blaze Burg
Reported 2014-03-10 15:05:36 PDT
It's trying to make a content view out of it, but that ain't gonna work. It's inside a try-catch block, so it doesn't actually break anything.
Attachments
Proposed Fix (2.09 KB, patch)
2015-08-01 12:55 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2014-03-12 11:48:29 PDT
Sounds like we just need to add the class to the early return in ReourceSidebarPanel._treeElementSelected. Or come up with a special function on these tree elements (isFolder()?) that we can check.
Brian Burg
Comment 2 2015-08-01 12:55:01 PDT
Created attachment 258014 [details] Proposed Fix
Joseph Pecoraro
Comment 3 2015-08-04 11:04:29 PDT
Comment on attachment 258014 [details] Proposed Fix This seems fine. I guess I wonder why ApplicationCacheManifestTreeElement is not a subclass of FolderTreeElement if it acts like a folder.
Blaze Burg
Comment 4 2015-08-04 11:21:24 PDT
(In reply to comment #3) > Comment on attachment 258014 [details] > Proposed Fix > > This seems fine. I guess I wonder why ApplicationCacheManifestTreeElement is > not a subclass of FolderTreeElement if it acts like a folder. It probably should be, or we should have a content view for the appcache manifest and change what appears for each frame that uses the same manifest. But there are larger problems with our app cache support (there are no real model objects to speak of; the content view directly unpacks protocol payloads), so I'd defer on further refactoring.
WebKit Commit Bot
Comment 5 2015-08-04 11:57:25 PDT
Comment on attachment 258014 [details] Proposed Fix Clearing flags on attachment: 258014 Committed r187872: <http://trac.webkit.org/changeset/187872>
WebKit Commit Bot
Comment 6 2015-08-04 11:57:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.