RESOLVED FIXED190238
Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy 
https://bugs.webkit.org/show_bug.cgi?id=190238
Summary Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
Ryosuke Niwa
Reported 2018-10-03 00:07:22 PDT
Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
Attachments
Enables the feature (13.93 KB, patch)
2018-10-03 00:09 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-sierra (2.58 MB, application/zip)
2018-10-03 01:18 PDT, EWS Watchlist 		no flags
Details
Patch for landing (15.92 KB, patch)
2018-10-03 01:51 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-10-03 00:09:46 PDT
Created attachment 351484 [details] Enables the feature
Ryosuke Niwa
Comment 2 2018-10-03 00:11:24 PDT
Apparently I forgot to disable this feature in WebKit2 when I initially added it in https://trac.webkit.org/changeset/236519 but it's still disabled in WebKit1. Enable it everywhere.
Ryosuke Niwa
Comment 3 2018-10-03 00:22:35 PDT
Comment on attachment 351484 [details] Enables the feature Let's actually wait for EWS.
EWS Watchlist
Comment 4 2018-10-03 01:18:21 PDT
Comment on attachment 351484 [details] Enables the feature Attachment 351484 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9437847 New failing tests: editing/pasteboard/copy-paste-across-shadow-boundaries-with-style-2.html editing/selection/selection-across-shadow-boundaries-readonly-3.html editing/pasteboard/copy-paste-across-shadow-boundaries-2.html editing/selection/selection-across-shadow-boundaries-readonly-2.html editing/pasteboard/copy-paste-across-shadow-boundaries-3.html editing/pasteboard/copy-paste-across-shadow-boundaries-4.html editing/pasteboard/copy-paste-with-shadow-content.html editing/selection/selection-across-shadow-boundaries-readonly-1.html editing/pasteboard/copy-paste-across-shadow-boundaries-with-style-1.html editing/pasteboard/copy-paste-across-shadow-boundaries-1.html
EWS Watchlist
Comment 5 2018-10-03 01:18:23 PDT
Created attachment 351490 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Ryosuke Niwa
Comment 6 2018-10-03 01:45:01 PDT
Oops, I forgot to fix DumpRenderTree.
Ryosuke Niwa
Comment 7 2018-10-03 01:51:05 PDT
Created attachment 351493 [details] Patch for landing
Ryosuke Niwa
Comment 8 2018-10-03 01:51:22 PDT
Comment on attachment 351493 [details] Patch for landing Wait for EWS again
Radar WebKit Bug Importer
Comment 9 2018-10-03 01:54:25 PDT
<rdar://problem/44967872>
Ryosuke Niwa
Comment 10 2018-10-03 02:45:20 PDT
Committed r236788: <https://trac.webkit.org/changeset/236788>
Note You need to log in before you can comment on or make changes to this bug.