WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
282170
[GTK] Use std::array and ASCIILiteral in KeyBindingTranslator.cpp
https://bugs.webkit.org/show_bug.cgi?id=282170
Summary
[GTK] Use std::array and ASCIILiteral in KeyBindingTranslator.cpp
Adrian Perez
Reported
2024-10-28 07:44:58 PDT
Same as with
bug #282095
: use std::array and ASCIILiteral in Source/WebKit/UIProcess/gtk/KeyBindingTranslator.cpp -- although in this case there weren't WTF_ALLOW_UNSAFE_BUFFER_USAGE_{BEGIN,END} and when building the GTK port with Clang warnings are always being produced -- I forgot to add the guards in this file.
Attachments
Add attachment
proposed patch, testcase, etc.
Adrian Perez
Comment 1
2024-10-28 08:01:47 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/35791
EWS
Comment 2
2024-10-28 19:04:35 PDT
Committed
285804@main
(57c6ca3ab9ef): <
https://commits.webkit.org/285804@main
> Reviewed commits have been landed. Closing PR #35791 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug